Fail registration without versioning behavior #1742
Merged
+44
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
approved these changes
Dec 4, 2024
ShahabT
reviewed
Dec 4, 2024
internal/workflow.go
Outdated
| @@ -413,8 +413,7 @@ type ( | |||
| // inside a workflow as a child workflow. | |||
| Name string | |||
| DisableAlreadyRegisteredCheck bool | |||
| // Optional: Provides a default Versioning Behavior to workflows of this type. | |||
| // See workflow.SetVersioningBehavior to override this default. | |||
| // Optional: Provides a Versioning Behavior to workflows of this type. | |||
There was a problem hiding this comment.
Should we mention that this is not optional of there is no default behavior and DeploymentOptions.UseBuildIDForVersioning==true?
There was a problem hiding this comment.
Good point, I'll make this more clear.
|
|
||
| ts.worker.Stop() | ||
| ts.workerStopped = true | ||
| w := worker.New(ts.client, ts.taskQueueName, worker.Options{ | ||
| w := worker.New(c, ts.taskQueueName, worker.Options{ | ||
| BuildID: "1.0", | ||
| UseBuildIDForVersioning: true, |
There was a problem hiding this comment.
is there any different between UseBuildIDForVersioning and DeploymentOptions.UseBuildIDForVersioning? Do we want to make UseBuildIDForVersioning exclusively for versioning 1-2 and the latter for versioning 3?
There was a problem hiding this comment.
There is no DeploymentOptions.UseBuildIDForVersioning until we deprecate versioning-2, otherwise it is just too confusing to have same field twice without deprecation.
antlai-temporal
merged commit 6631916
into
temporalio:versioning-3
10 of 12 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Remove programmatic SetVersioningBehavior API, and fail workflow registration when behavior missing.See #1739 for details.
Fail registration of workflow types without versioning behavior #1739
One system test