Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SpanFromWorkflowContext function #1711

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Added SpanFromWorkflowContext function #1711

merged 1 commit into from
Nov 22, 2024

Conversation

cdimitroulas
Copy link
Contributor

What was changed

Added a SpanFromWorkflowContext function to allow access to the DataDog span object from within a workflow.

Why?

This allows users to access the Span from within a workflow to (for example) add custom tags on the span.

Checklist

  1. Closes go.temporal.io/sdk/contrib/datadog to provide way to access DataDog spans from within a workflow #1701
  2. How was this tested: New unit test added
  1. Any docs updates needed? Would be nice, please let me know where I could add these if this is desired.

@cdimitroulas cdimitroulas requested a review from a team as a code owner November 19, 2024 17:53
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cretz
cretz approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @Quinn-With-Two-Ns review

@cdimitroulas cdimitroulas force-pushed the datadog/span-from-workflow-context branch from 51e2140 to da19eda Compare November 20, 2024 16:07
@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the datadog/span-from-workflow-context branch from da19eda to c9f594e Compare November 21, 2024 22:48
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 99a35d4 into temporalio:master Nov 22, 2024
13 checks passed
@cdimitroulas cdimitroulas deleted the datadog/span-from-workflow-context branch November 26, 2024 14:03
ReyOrtiz pushed a commit to ReyOrtiz/temporal-sdk-go that referenced this pull request Dec 5, 2024
@cdimitroulas @reynieroz
Added SpanFromWorkflowContext function (temporalio#1711)
439d45a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go.temporal.io/sdk/contrib/datadog to provide way to access DataDog spans from within a workflow
4 participants
@cdimitroulas @CLAassistant @cretz @Quinn-With-Two-Ns