Add Nexus links tests #1613
Add Nexus links tests #1613
Conversation
| require.Equal(t, tc.testConfig.Namespace, link.GetWorkflowEvent().GetNamespace()) | ||
| require.Equal(t, handlerWfID, link.GetWorkflowEvent().GetWorkflowId()) | ||
| require.NotEmpty(t, link.GetWorkflowEvent().GetRunId()) | ||
| requireProtoEqual( | ||
| t, | ||
| &common.Link_WorkflowEvent_EventReference{ | ||
| EventType: enums.EVENT_TYPE_WORKFLOW_EXECUTION_STARTED, | ||
| }, | ||
| link.GetWorkflowEvent().GetEventRef()) | ||
| handlerRunID := link.GetWorkflowEvent().GetRunId() |
There was a problem hiding this comment.
nit: you could have just used requireProtoEqual on the entire struct.
There was a problem hiding this comment.
I cannot because I don't have the handler run id.
| @@ -290,10 +298,22 @@ func TestNexusWorkflowRunOperation(t *testing.T) { | |||
|
|
|||
| nc := tc.newNexusClient(t, service.Name) | |||
|
|
|||
| link := &common.Link_WorkflowEvent{ | |||
There was a problem hiding this comment.
This is redundant IMHO since we're already testing adding links from a workflow.
There was a problem hiding this comment.
I missed this in the last PR but please mark these functions as experimental in a different PR since this one has to remain a draft until we have a CLI with server 1.26.
https://github.com/temporalio/sdk-go/blob/master/temporalnexus/link_converter.go#L65-L89
rodrigozhou
force-pushed
the
rodrigozhou/nexus-test-links
branch
from
a78bfbf to
d57a2c5
Compare
| @@ -31,6 +31,7 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/google/go-cmp/cmp" | |||
There was a problem hiding this comment.
Is it worth a new test dependency just to show a diff in this one test that should never happen anyways? I think https://pkg.go.dev/google.golang.org/protobuf/proto#Equal should be good enough for this case right?
What was changed
Add Nexus links tests
Why?
Checklist
Closes
How was this tested: