Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDK version and name to history #1245

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Add SDK version and name to history #1245

merged 3 commits into from
Sep 25, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Add SDK name and version to the SDK metadata on WFT complete. Only write if this is the first time or a change.

closes #1194

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner September 20, 2023 18:23
cretz
cretz approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't dig into task processing details, but seems with the updated bool check that there is low possibility of this value flapping between workers.

internal/internal_event_handlers.go Outdated Show resolved Hide resolved
@Quinn-With-Two-Ns
Copy link
Contributor Author

Quinn-With-Two-Ns commented Sep 25, 2023 •
edited
Loading

LGTM. Didn't dig into task processing details, but seems with the updated bool check that there is low possibility of this value flapping between workers.

@cretz Did you mean it would flap if the two workers had different versions of the SDK?

@cretz
Copy link
Member

cretz commented Sep 25, 2023

Did you mean it would flap if the two workers had different versions of the SDK?

Nah, that would be expected. Just confirming the "updated" bools work as expected since it gets a bit confusing in there when set/unset. But your test confirming subsequent tasks don't have the values set is probably good enough.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 59d8488 into temporalio:master Sep 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sdk-name and sdk-version in task-level metadata if changed
2 participants
@Quinn-With-Two-Ns @cretz