Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable running sessions on a versioned worker #1241

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Disable running sessions on a versioned worker #1241

merged 1 commit into from
Sep 24, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Disable running sessions and versioned workers together because they are not currently compatible

closes #1234

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner September 19, 2023 16:22
cretz
cretz approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ug, hate that we have to panic, but it is the best way in this situation (no error and don't want to wait until start/run to fail)

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 6039cd3 into temporalio:master Sep 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable creating a session worker and a versioned worker together
2 participants
@Quinn-With-Two-Ns @cretz