Rename fields, add comments

temporalio · Dec 5, 2024 · f81297c · f81297c
1 parent 33b91c8
commit f81297c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/internal/deployment_client.go b/internal/deployment_client.go
@@ -99,8 +99,8 @@ type (
 		// CreateTime - When this deployment was created.
 		CreateTime time.Time
 
-		// Current - Whether this deployment is the current one for its deployment series.
-		Current bool
+		// IsCurrent - Whether this deployment is the current one for its deployment series.
+		IsCurrent bool
 
 		// TaskQueuesInfo - List of task queues polled by workers in this deployment.
 		TaskQueuesInfo []DeploymentTaskQueueInfo
@@ -119,7 +119,7 @@ type (
 		CreateTime time.Time
 
 		// Whether this deployment is the current one for its deployment series.
-		Current bool
+		IsCurrent bool
 	}
 
 	// DeploymentListIterator is an iterator for deployments.
@@ -147,7 +147,7 @@ type (
 	// DeploymentReachabilityInfo extends DeploymentInfo with reachability information.
 	// NOTE: Experimental
 	DeploymentReachabilityInfo struct {
-		DeploymentInfo
+		DeploymentInfo DeploymentInfo
 
 		// Reachability - Kind of tasks that may reach a worker
 		// associated with a deployment.

diff --git a/internal/internal_deployment_client.go b/internal/internal_deployment_client.go
@@ -95,7 +95,7 @@ func deploymentListEntryFromProto(deployment *deployment.DeploymentListInfo) *De
 	return &DeploymentListEntry{
 		Deployment: deploymentFromProto(deployment.GetDeployment()),
 		CreateTime: deployment.GetCreateTime().AsTime(),
-		Current:    deployment.GetIsCurrent(),
+		IsCurrent:  deployment.GetIsCurrent(),
 	}
 }
 
@@ -115,7 +115,7 @@ func deploymentInfoFromProto(deploymentInfo *deployment.DeploymentInfo) Deployme
 	return DeploymentInfo{
 		Deployment:     deploymentFromProto(deploymentInfo.GetDeployment()),
 		CreateTime:     deploymentInfo.GetCreateTime().AsTime(),
-		Current:        deploymentInfo.GetIsCurrent(),
+		IsCurrent:      deploymentInfo.GetIsCurrent(),
 		TaskQueuesInfo: deploymentTaskQueuesInfoFromProto(deploymentInfo.GetTaskQueueInfos()),
 		Metadata:       deploymentInfo.GetMetadata(),
 	}

diff --git a/internal/workflow.go b/internal/workflow.go
@@ -413,7 +413,9 @@ type (
 		// inside a workflow as a child workflow.
 		Name                          string
 		DisableAlreadyRegisteredCheck bool
-		// Optional: Provides a Versioning Behavior to workflows of this type.
+		// Optional: Provides a Versioning Behavior to workflows of this type. It is required
+		// when WorkerOptions does not specify DeploymentOptions.DefaultVersioningBehavior,
+		// DeploymentOptions.DeploymentSeriesName is set, and UseBuildIDForVersioning is true.
 		// NOTE: Experimental
 		VersioningBehavior VersioningBehavior
 	}