Skip to content

Commit

Permalink
Tweak docs
Browse files Browse the repository at this point in the history
  • Loading branch information
dandavison committed Dec 5, 2024
1 parent 5714ad8 commit d8ae5f5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
19 changes: 11 additions & 8 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ type (
UpdateWorkflowOptions = internal.UpdateWorkflowOptions

// UpdateWithStartWorkflowOptions encapsulates the parameters used by UpdateWithStartWorkflow.
// See [Client.UpdateWithStartWorkflow].
// See [Client.UpdateWithStartWorkflow] and [Client.NewWithStartWorkflowOperation].
// NOTE: Experimental
UpdateWithStartWorkflowOptions = internal.UpdateWithStartWorkflowOptions

Expand Down Expand Up @@ -846,13 +846,16 @@ type (
UpdateWorkflow(ctx context.Context, options UpdateWorkflowOptions) (WorkflowUpdateHandle, error)

// UpdateWithStartWorkflow issues an update-with-start request. A
// WorkflowIDConflictPolicy must be set. If the specified workflow is
// not running, then a new workflow execution is started and the update
// is sent in the first workflow task. Alternatively if the specified
// workflow is running then, if the WorkflowIDConflictPolicy is
// USE_EXISTING, the update is issued against the specified workflow,
// and if the WorkflowIDConflictPolicy is FAIL, an error is returned.
//
// WorkflowIDConflictPolicy must be set in the options. If the specified
// workflow execution is not running, then a new workflow execution is
// started and the update is sent in the first workflow task.
// Alternatively if the specified workflow execution is running then, if
// the WorkflowIDConflictPolicy is USE_EXISTING, the update is issued
// against the specified workflow, and if the WorkflowIDConflictPolicy
// is FAIL, an error is returned. The call will block until the update
// has reached the WaitForStage in the options. Note that this means
// that the call will not return successfully until the update has been
// delivered to the worker service.
// NOTE: Experimental
UpdateWithStartWorkflow(ctx context.Context, options UpdateWithStartWorkflowOptions) (WorkflowUpdateHandle, error)

Expand Down
4 changes: 2 additions & 2 deletions internal/internal_workflow_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -803,8 +803,8 @@ type UpdateWorkflowOptions struct {
FirstExecutionRunID string
}

// UpdateWithStartWorkflowOptions encapsulates the parameters for update-with-start.
// See [UpdateWithStartWorkflow].
// UpdateWithStartWorkflowOptions encapsulates the parameters used by UpdateWithStartWorkflow.
// See UpdateWithStartWorkflow and NewWithStartWorkflowOperation.
// NOTE: Experimental
type UpdateWithStartWorkflowOptions struct {
StartWorkflowOperation WithStartWorkflowOperation
Expand Down

0 comments on commit d8ae5f5

Please sign in to comment.