Have Opentelemetry error handler to use tracing::error #852
Conversation
| global::set_error_handler(|err| { | ||
| tracing::error!("{}", err); | ||
| })?; |
There was a problem hiding this comment.
I wonder if there is a better more global place to set this instead of on each build_otlp_metric_exporter call? Unsure if we have global metric initialization code.
| @@ -120,6 +120,9 @@ pub(super) fn augment_meter_provider_with_defaults( | |||
| pub fn build_otlp_metric_exporter( | |||
| opts: OtelCollectorOptions, | |||
| ) -> Result<CoreOtelMeter, anyhow::Error> { | |||
| global::set_error_handler(|err| { | |||
There was a problem hiding this comment.
Note this was removed recently in 0.27 (ref open-telemetry/opentelemetry-rust#2260), so we either need to say in the dep that we are 0.26 (not sure if you can say < 0.27) or look at that migration guide and see if just upgrading to 0.27 is enough to get proper logs here.
There was a problem hiding this comment.
I believe the change only changes the behavior on how you can override their default logging behavior, we would still need to override their behavior, just in a different way now. I'm not sure it's worth upgrading to 0.27 over this.
What was changed
Set OpenTelemetry global setting to log to
tracing::errorWhy?
Checklist
Closes [Feature Request] Have OpenTelemetry failure logs go to logger instead of stderr #810
How was this tested: