Call ShutdownWorker API on worker shutdown #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Nov 18, 2024
core/src/core_tests/workers.rs
Outdated
Comment on lines
403
to
404
| #[tokio::test] | ||
| async fn worker_shutdown_non_sticky() { |
There was a problem hiding this comment.
All three of these tests share a lot of code and could be combined using the rstest macro - check out the other places that's used to get an idea of how to do it.
core/src/worker/mod.rs
Outdated
| @@ -470,6 +470,11 @@ impl Worker { | |||
| /// completed | |||
| async fn shutdown(&self) { | |||
| self.initiate_shutdown(); | |||
| // Call shutdownWorker API to initiate server side shutdown | |||
There was a problem hiding this comment.
Can just get rid of this comment. Comments of the form "I'm about to do X" followed by a very easily-read "X" are usually unnecessary.
sdk-core-protos/Cargo.toml
Outdated
| @@ -30,7 +31,7 @@ uuid = { version = "1.1", features = ["v4"], optional = true } | |||
|
|
|||
| [build-dependencies] | |||
| tonic-build = { workspace = true } | |||
| prost-build = "0.13" | |||
| prost-build = "0.11.7" | |||
cretz
reviewed
Nov 19, 2024
core/src/worker/mod.rs
Outdated
Comment on lines
506
to
507
| // This is a best effort call and we can still shutdown the worker if it fails | ||
| let _ = self.client.shutdown_worker(name).await; |
There was a problem hiding this comment.
I think we should warn if this is any Err except Unavailable (maybe dbg_panic too). Otherwise this is the type of thing that will just stop working and we'll never know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a new call to ShutdownWorker that was recently implemented in the server.
Why?
New server feature already implemented in Go and Java, implementing in core to match.
Checklist
Closes [Feature Request] Call ShutdownWorker API on worker shutdown #822
How was this tested:
Add tests to verify when API is called