Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mpsc instead crossbeam-channel #826

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Use mpsc instead crossbeam-channel #826

merged 5 commits into from
Oct 10, 2024

Conversation

negezor
Copy link
Contributor

@negezor negezor commented Oct 6, 2024

What was changed

Replaced crossbeam-channel crate with std::sync::mpsc

Why?

Noticed that crossbeam-channel is being used unnecessarily.

Checklist

  1. How was this tested:
    Run cargo test

@negezor negezor requested a review from a team as a code owner October 6, 2024 18:18
Sushisource
Sushisource approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@Sushisource Sushisource merged commit 90ef5ca into temporalio:master Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@negezor @Sushisource