Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated patch removal when no subequent command #671

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

Sushisource
Copy link
Member

What was changed

Fixes a bug where removing a deprecated patch call could trigger nondeterminism if there is no subsequent command

Why?

Bugfix

Checklist

  1. Closes [Bug] Deprecate patch removal with no subsequent command can cause nondeterminism  #670

  2. How was this tested:
    Added integ test

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner January 16, 2024 22:32
@Sushisource Sushisource merged commit f673f1d into temporalio:master Jan 17, 2024
7 checks passed
@Sushisource Sushisource deleted the deprecated-patch-bug branch January 17, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Deprecate patch removal with no subsequent command can cause nondeterminism
2 participants