Fix worker shutdown during replay test #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Nov 14, 2023
client/src/worker_registry/mod.rs
Outdated
Comment on lines
116
to
117
| /// True if this manager is associated with a mock client. | ||
| mock: bool, |
There was a problem hiding this comment.
Rather than adding this here, I think it would be a little cleaner to add is_mock to the WorkerClient trait and simply not instantiate / merge the external WFT channel if it is.
There was a problem hiding this comment.
Moved to WorkerClient.
The only reason to merge the closed stream is to satisfy the Rust typing gods... Select is not the same type as Stream, is there a way to cast it into a vanilla Stream?
There was a problem hiding this comment.
Thanks for your great suggestion of using an Either stream! Channel not merged.
Sushisource
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #630 by closing the external channel early when we are using a mock client associated with the worker.
This will disable Eager Start Workflow with mock clients, but since ESW is a latency optimization, and we do not use mock clients during its testing, this has no practical consequences.
[Bug] Shutdown worker after replay test #630