Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set trace subscriber when useful #602

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Only set trace subscriber when useful #602

merged 3 commits into from
Sep 1, 2023

Conversation

Sushisource
Copy link
Member

What was changed

Do not register a trace subscriber on threads unless the telemetry config actually asked to do anything.

Why?

Causes problems with user created global subscribers

Checklist

  1. Closes [Bug] Workers crashes when setting a global tracing_subscriber #601

  2. How was this tested:
    Existing tests

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner August 31, 2023 23:02
@Sushisource Sushisource merged commit 28f8b2b into temporalio:master Sep 1, 2023
3 checks passed
@Sushisource Sushisource deleted the no-set-unwanted-tracing-subscriber branch September 1, 2023 00:06
@mjameswh mjameswh mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Workers crashes when setting a global tracing_subscriber
2 participants
@Sushisource @bergundy