Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NestJS sample #393

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Update NestJS sample #393

merged 3 commits into from
Dec 3, 2024

Conversation

MBach
Copy link
Contributor

@MBach MBach commented Nov 21, 2024

What was changed

  • The NestJS sample was rewritten in a more "real world" style
  • Readme was updated
  • Webpack for production, default (tsc) for development

Why?

  • NPM scripts weren't working properly
  • Repository was using outdated NestJS framework

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mjameswh
mjameswh approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @MBach. C'est très apprécié!

@mjameswh mjameswh merged commit 84b5237 into temporalio:main Dec 3, 2024
73 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjameswh mjameswh mjameswh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBach @CLAassistant @mjameswh