Skip to content

Commit

Permalink
fix(tests): Avoid Node v22.12.0 on Windows (#402)
Browse files Browse the repository at this point in the history
  • Loading branch information
mjameswh authored Dec 18, 2024
1 parent 2a44e13 commit c87e4a6
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ jobs:
nestjs-exchange-rates,
timer-examples
]
include:
- os: windows-latest
node: 22
node-release-override: 22.11.0

steps:
- uses: actions/checkout@v4
Expand All @@ -38,7 +42,11 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
# Node 22.12.0 on Windows incorrectly resolves `localhost` to `::1`, rather than both `::1` and `127.0.0.1`.
# THis causes errors when executing tests. So until this gets fixed upstream, we force the last known good
# version of Node on Windows.
# See https://github.com/nodejs/node/issues/56137 (_resolved_ already, but not yet released).
node-version: ${{ matrix.node-release-override || matrix.node }}
# Comment out cache line when testing with act:
# (Test command is: act --platform ubuntu-latest=lucasalt/act_base:latest)
cache: 'pnpm'
Expand Down

0 comments on commit c87e4a6

Please sign in to comment.