Skip to content

Commit

Permalink
Update Node version (#394)
Browse files Browse the repository at this point in the history
  • Loading branch information
josh-berry authored Nov 27, 2024
1 parent 08df93c commit ac6e079
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
node: [ 16, 18, 20 ]
node: [ 18, 20, 22 ]
project:
[
activities-examples,
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
# Comment out cache line when testing with act:
# (Test command is: act --platform ubuntu-latest=lucasalt/act_base:latest)
cache: 'npm'
Expand Down
9 changes: 7 additions & 2 deletions custom-logger/src/logging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,13 @@ const devLogFormat = winston.format.printf(({ level, message, label, timestamp,
// The type signature in winston is wrong
const { [LEVEL]: _lvl, [SPLAT]: _splt, [MESSAGE]: _msg, ...restNoSymbols } = rest as Record<string | symbol, any>;
return Object.keys(restNoSymbols).length === 0
? `${getDateStr(timestamp)} [${label}] ${level}: ${message}`
: `${getDateStr(timestamp)} [${label}] ${level}: ${message} ${util.inspect(restNoSymbols, false, 4, true)}`;
? `${getDateStr(timestamp as number)} [${label}] ${level}: ${message}`
: `${getDateStr(timestamp as number)} [${label}] ${level}: ${message} ${util.inspect(
restNoSymbols,
false,
4,
true
)}`;
});

/** Create a winston logger from given options */
Expand Down
2 changes: 1 addition & 1 deletion food-delivery/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"vercel": "^29.0.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=22.0.0"
},
"packageManager": "[email protected]"
}

0 comments on commit ac6e079

Please sign in to comment.