Update hello_search_attributes.py with new typed search attribute syntax #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old example used deprecated syntax
|
|
|
|
cretz
reviewed
Oct 7, 2024
hello/hello_search_attributes.py
Outdated
| @@ -28,23 +31,26 @@ async def main(): | |||
| # While the worker is running, use the client to start the workflow. | |||
| # Note, in many production setups, the client would be in a completely | |||
| # separate process from the worker. | |||
| custom_keyword_field = SearchAttributeKey.for_keyword("CustomKeywordField") | |||
There was a problem hiding this comment.
Could even make this a global if you'd like and reuse it in the workflow too. At the very least, define it at the top of this function instead of redefining within the function.
|
Thanks! Left a comment. May also need to sign the CLA. |
define at top of workflow for reuse.
|
May need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old example used deprecated syntax
What was changed
Update hello_search_attributes.py with new typed search attribute syntax
Why?
Old example used deprecated syntax