fix: violation of the DRY principle

temporalio · Dec 10, 2024 · 5ded808 · 5ded808
1 parent 0763309
commit 5ded808
Showing 1 changed file with 11 additions and 28 deletions.
diff --git a/hello/hello_activity_choice.py b/hello/hello_activity_choice.py
@@ -59,39 +59,22 @@ async def run(self, list: ShoppingList) -> str:
         ordered: List[str] = []
         for item in list.items:
             if item.fruit is Fruit.APPLE:
-                ordered.append(
-                    await workflow.execute_activity(
-                        order_apples,
-                        item.amount,
-                        start_to_close_timeout=timedelta(seconds=5),
-                    )
-                )
+                order_function = order_apples
             elif item.fruit is Fruit.BANANA:
-                ordered.append(
-                    await workflow.execute_activity(
-                        order_bananas,
-                        item.amount,
-                        start_to_close_timeout=timedelta(seconds=5),
-                    )
-                )
+                order_function = order_bananas
             elif item.fruit is Fruit.CHERRY:
-                ordered.append(
-                    await workflow.execute_activity(
-                        order_cherries,
-                        item.amount,
-                        start_to_close_timeout=timedelta(seconds=5),
-                    )
-                )
+                order_function = order_cherries
             elif item.fruit is Fruit.ORANGE:
-                ordered.append(
-                    await workflow.execute_activity(
-                        order_oranges,
-                        item.amount,
-                        start_to_close_timeout=timedelta(seconds=5),
-                    )
-                )
+                order_function = order_oranges
             else:
                 raise ValueError(f"Unrecognized fruit: {item.fruit}")
+            ordered.append(
+                await workflow.execute_activity(
+                    order_function,
+                    item.amount,
+                    start_to_close_timeout=timedelta(seconds=5),
+                )
+            )
         return "".join(ordered)