#74 bug(timeout): increase worflow pool timeout

#74 bug(timeout): increase workflow pool timeout
temporalio · Jun 24, 2021 · bb7cc73 · bb7cc73
2 parents 9e6bf02 + 148a728
commit bb7cc73
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/activity/activity_pool.go b/activity/activity_pool.go
@@ -70,7 +70,6 @@ func newActivityPool(codec rrt.Codec, graceTimeout time.Duration, listener event
 	}, nil
 }
 
-// initWorkers request workers info from underlying PHP and configures temporal workers linked to the pool.
 func (pool *activityPoolImpl) Start(ctx context.Context, temporal client.Temporal) error {
 	const op = errors.Op("activity_pool_start")
 	pool.dc = temporal.GetDataConverter()
@@ -90,7 +89,6 @@ func (pool *activityPoolImpl) Start(ctx context.Context, temporal client.Tempora
 	return nil
 }
 
-// initWorkers request workers info from underlying PHP and configures temporal workers linked to the pool.
 func (pool *activityPoolImpl) Destroy(ctx context.Context) error {
 	for i := 0; i < len(pool.tWorkers); i++ {
 		pool.tWorkers[i].Stop()

diff --git a/workflow/worker.go b/workflow/worker.go
@@ -62,7 +62,13 @@ func newPool(codec rrt.Codec, factory server.Server, graceTimeout time.Duration,
 	env := map[string]string{RR_MODE: roadrunner_temporal.RRMode, RR_CODEC: codec.GetName()}
 
 	cfg := rrPool.Config{
-		NumWorkers: 1,
+		Debug:           false,
+		NumWorkers:      1,
+		MaxJobs:         0,
+		AllocateTimeout: time.Hour * 240,
+		DestroyTimeout:  time.Second * 30,
+		// no supervisor for the workflow worker
+		Supervisor: nil,
 	}
 
 	p, err := factory.NewWorkerPool(