Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI comamnd for UpdateActivityOptions API #729

Open
wants to merge 4 commits into
base: next-server
Choose a base branch
from

Conversation

ychebotarev
Copy link

@ychebotarev ychebotarev commented Dec 13, 2024

What was changed

Add update-options to the CLI
(note - I closed previous PR for main)

Why?

To support UpdateActivity API

Checklist

  1. Closes

  2. How was this tested:

Add tests.

  1. Any docs updates needed?

Yes, but not in this PR.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing blocking, though would like @josh-berry to look or get another opinion at least

temporalcli/commands.activity.go Outdated Show resolved Hide resolved
temporalcli/commands.activity_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants