Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change log-format to string-enum #711

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

yuandrew
Copy link
Contributor

What was changed

addressed #677 (comment) regarding "pretty" as a legacy alias for "text"

to accomplish this, added a new hidden-legacy-values field that can be used to deprecate options in the future

Why?

better argument typing

Checklist

  1. How was this tested:

added a test to test --log-format pretty works

@yuandrew yuandrew merged commit ab24c30 into temporalio:main Nov 19, 2024
7 checks passed
@yuandrew yuandrew deleted the pretty-legacy-alias branch November 19, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants