Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched go versions (and AS casing) #702

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

LeeBrotherston
Copy link
Contributor

@LeeBrotherston LeeBrotherston commented Oct 31, 2024

What was changed

  • Updated the image for building from golang:1.22-bookworm to golang:1.23-bookworm in the Dockerfile
  • Changed casing on AS statement to match the rest of the Dockerfile

Why?

  • Dockerfile was using golang:1.22-bookworm as the builder image, but go.mod requires >= 1.23, and so the docker image build fails.
  • The case of the AS keyword was causing a (non fatal) build error in Docker

Checklist

  1. Closes n/a

  2. How was this tested:
    docker build . the original version, observe the errors...

 => ERROR [builder 4/4] RUN go build ./cmd/temporal                                                                                                                                                             0.2s
------                                                                                                                                                                                                               
 > [builder 4/4] RUN go build ./cmd/temporal:
0.146 go: go.mod requires go >= 1.23 (running go 1.22.8; GOTOOLCHAIN=local)
------

 1 warning found (use docker --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
Dockerfile:9
--------------------

docker build . this version and observe that these errors are not present

  1. Any docs updates needed?

no.

Dockerfile was using golang:1.22-bookworm as the builder image, but
go.mod requires >= 1.23, and so the docker image would not build.

Also fixed a complaint that 'AS' was lowercase when 'FROM' is uppercase.
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cretz cretz merged commit 051ef29 into temporalio:main Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants