-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Describe-TQ
Command Description
#684
Improving Describe-TQ
Command Description
#684
Conversation
Such tasks are not counted by these metrics. Despite the inaccuracy of | ||
these two metrics, the derived metric of `BacklogIncreaseRate` is accurate | ||
for backlogs older than a few seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to contradict the statement above re. the Backlog Increase Rate:
This is equivalent to:
`TasksAddRate` - `TasksDispatchRate`.
(Also, should it be BacklogIncreaseRate
, not Backlog Increase Rate
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what that statement means to say is that: Despite the inaccuracies put forward by the two metrics (wrt not counting eagerly dispatched tasks, the BacklogIncreaseRate
metric is an accurate estimate for the number of tasks that are actually present in the backlog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be pedantic but let's change that text to then read: "This is roughly equivalent to"—if we say "This is equivalent to", someone will probably expect to be able to do math and get the same result, and it sounds like that's not the case.
Also, still same question about the spaces in Backlog Increase Rate
—can you also change that while you're here if it's supposed to be BacklogIncreaseRate
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to address that in my response but had made the change locally. Yes, I shall be changing Backlog Increase Rate to the required output.
Made the changes required as well; thank you for taking a peek at this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being patient with my nitpicking. :)
What was changed
Why?
Checklist
Closes
How was this tested: