Batch operation rate limit #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cdbe10e.
stephanos
commented
Mar 20, 2024
| @@ -83,8 +83,10 @@ func ListBatchJobs(c *cli.Context) error { | |||
| // BatchTerminate terminate a list of workflows | |||
| func BatchTerminate(c *cli.Context) error { | |||
| operator := common.GetCurrentUserFromEnv() | |||
| rps := float32(c.Float64(common.FlagRPS)) | |||
There was a problem hiding this comment.
AFAICT, the CLI library doesn't have a built-in Float32 flag, so we need to downcast here. Which is fine; the required precision we expect here will most likely never be more than 2 decimals.
stephanos
commented
Mar 20, 2024
| FlagQueryTerminate = "Terminate Workflow Executions with given List Filter." | ||
| FlagEventIDDefinition = "The Event Id for any Event after WorkflowTaskStarted you want to reset to (exclusive). It can be WorkflowTaskCompleted, WorkflowTaskFailed or others." | ||
| FlagQueryResetBatch = "Visibility Query of Search Attributes describing the Workflow Executions to reset. See https://docs.temporal.io/docs/tctl/workflow/list#--query." |
There was a problem hiding this comment.
To align it with the other flags, I changed this into FlagQueryReset and standardized the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ This is a redo of #366 that was reverted since it was merged prematurely.
What was changed
Added a new flag
--rpsto the 4 batch operations.Note that although
batch-resetis a batch operation, it performs its work locally instead of on the server - so the flag does not apply here.Why?
To fix temporalio/temporal#4926.
Checklist
Closes OSS-1681
How was this tested: