Allow passing multiple --input-files to workflow commands [#351]
#361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for how to pass multiple arguments was just wrong--`json.Unmarshal()` does not support parsing multi-line JSON inputs as separate values. Fix this by accepting multiple `--input-file` flags, parsing each one separately, and turning each file into a distinct argument. Also, check and throw an error if the user tries to use both `--input` and `--input-file`, since the old behavior--silently ignoring `--input` if `--input-file` is specified--was surprising.
dandavison
approved these changes
Oct 16, 2023
|
|
||
| s.Assert().Equal("[1,\"two\",{\"three\":3},[\"a\",\"b\",\"c\"]]", result) | ||
| } | ||
|
|
There was a problem hiding this comment.
This isn't blocking, but just noting that running a real workflow to completion involves quite a lot of machinery that's not related to argument handling. It might be nice to come up with a more directed way to do this.
There was a problem hiding this comment.
I agree; there are a lot of ways to handle this (e.g. checking the workflow arguments server-side without waiting for completion, mocking out parts of the CLI so we don't even need a server, etc.). This was just the most expedient.
cretz
reviewed
Oct 17, 2023
josh-berry
added a commit
that referenced
this pull request
Oct 17, 2023
Chad gave me a few style suggestions after I merged #361--this applies those style suggestions.
josh-berry
added a commit
that referenced
this pull request
Oct 20, 2023
Chad gave me a few style suggestions after I merged #361--this applies those style suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for how to pass multiple arguments was just wrong--
json.Unmarshal()does not support parsing multi-line JSON inputs as separate values.Fix this by accepting multiple
--input-fileflags, parsing each one separately, and turning each file into a distinct argument.Also, check and throw an error if the user tries to use both
--inputand--input-file, since the old behavior--silently ignoring--inputif--input-fileis specified--was surprising.