GHA to create tag/release #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give some background on the savings here on starting a GH workflow vs publishing release in GH? |
rodrigozhou
force-pushed
the
rodrigozhou/gha-create-tag
branch
from
5d836bc to
bddfbea
Compare
cretz
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
As mentioned at temporalio/api-go#170 (review), I am a bit concerned about the maintenance of these two workflows for such an incredibly simple thing, but if y'all are resolving to maintain them and are now in full control of the release process of this and the API repo, ok.
rodrigozhou
force-pushed
the
rodrigozhou/gha-create-tag
branch
from
bddfbea to
d0cd2bf
Compare
cretz
approved these changes
Dec 10, 2024
rodrigozhou
force-pushed
the
rodrigozhou/gha-create-tag
branch
from
d0cd2bf to
2cab9a7
Compare
bergundy
reviewed
Dec 12, 2024
| tag: | ||
| description: "Tag for new version (v1.23.4)" | ||
| required: true | ||
| create_release: |
There was a problem hiding this comment.
We should always require a release IMHO, it's part of our release process.
| base_tag: | ||
| description: "Base tag to generate commit list for release notes" | ||
| required: false | ||
| skip_sdk_check: |
| if [[ "${TAG}" =~ ^v.* ]]; then | ||
| echo "tag=${TAG}" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "tag=v${TAG}" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Don't do this, let users provide the proper version and avoid surprises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
GHA to create tag and release.
Added an option to trigger workflow in api-go to create a release.
Why?
Automation.
Breaking changes
Server PR