Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IngressRouteTCP for Stopped Instances #1058

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove IngressRouteTCP for Stopped Instances #1058

wants to merge 6 commits into from

Conversation

joshuajerin
Copy link
Contributor

@joshuajerin joshuajerin commented Nov 25, 2024 •
edited
Loading

@joshuajerin joshuajerin changed the title Delete IngressRouteTCP when spec.stop=true Remove IngressRouteTCP when spec.stop=true Nov 25, 2024
@joshuajerin joshuajerin changed the title Remove IngressRouteTCP when spec.stop=true Remove IngressRouteTCP for Stopped Instances Nov 25, 2024
@joshuajerin joshuajerin marked this pull request as ready for review November 25, 2024 16:15
joshuajerin
joshuajerin commented Nov 26, 2024
View reviewed changes
tembo-operator/src/cloudnativepg/hibernate.rs Outdated
return Err(Action::requeue(Duration::from_secs(300)));
}

let prefix_extra = format!("extra-{}-rw", cdb.name_any().as_str());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabbed this from here

tembo/tembo-operator/src/ingress.rs

Line 95 in 5b154ff

let ingress_route_tcp_name = format!("extra-{}-rw", cdb.name_any());

nhudson
nhudson requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@nhudson nhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it might also be best to add some tests for this in the intergration test. You should be able to add some asserts in the functional_test_hibernate test to check if the IngressRouteTCP was removed or not.

tembo-operator/src/cloudnativepg/hibernate.rs Outdated Show resolved Hide resolved
tembo-operator/src/cloudnativepg/hibernate.rs Outdated Show resolved Hide resolved
nhudson
nhudson approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@nhudson nhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am going to go ahead and approve, but we should figure out why the tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhudson nhudson nhudson approved these changes

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

@ChuckHend ChuckHend Awaiting requested review from ChuckHend ChuckHend is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuajerin @nhudson