Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedup and change order of appService env vars #1036

Merged
merged 4 commits into from
Nov 6, 2024
Merged

dedup and change order of appService env vars #1036

merged 4 commits into from
Nov 6, 2024

Conversation

ChuckHend
Copy link
Member

  • apply the instance env vars last
  • collects appService env vars in hashmap so that we can ensure there are no duplicate env var names

@ChuckHend ChuckHend merged commit 402e925 into main Nov 6, 2024
9 checks passed
@ChuckHend ChuckHend deleted the env-order branch November 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhudson nhudson nhudson approved these changes

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChuckHend @nhudson