-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting Started Article Revamp #561
base: master
Are you sure you want to change the base?
Conversation
></grid> | ||
</template> | ||
``` | ||
1. Implement the paging and sorting functionality in the `data` option: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The composition API doesn't have a 'data' option. Probably this is taken from the Options API article or is here because of the copy-paste process when creating the currently available getting started articles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reused the content of the current article on line 281 but I may have misinterpreted it. What wording and terms should I use instead?
docs/getting-started/index.md
Outdated
filter: filter.value | ||
``` | ||
|
||
1. Define the Grid in the `<script>` block. Add user-friendly [column titles](slug:api_grid_gridcolumnprops#toc-title) by using the `title` property: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version of the Composition API uses the <script setup> configuration as in the following code:
<script setup>
import { ref, onMounted } from 'vue'
// reactive state
const count = ref(0)
// functions that mutate state and trigger updates
function increment() {
count.value++
}
// lifecycle hooks
onMounted(() => {
console.log(`The initial count is ${count.value}.`)
})
</script>
<template>
<button @click="increment">Count is: {{ count }}</button>
</template>
Let's make the composition API examples using the <script setup>
docs/getting-started/index.md
Outdated
* Set the initial [sorting](slug:api_grid_gridprops#toc-sort) by Product name. | ||
|
||
```js | ||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same as above. Let's use the <script setup> configuration of the Composition API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added placeholder code snippets, could you provide the actual code?
221763e
This PR updates the main Getting Started article (Composition API + JS). The main changes are:
Outstanding tasks: