Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html specs corrections 6 #5230

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Html specs corrections 6 #5230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73a7355
fix(html): add toolbar-button class to toolbar buttons in AI prompt
TeyaVes Nov 13, 2024
fb5d7d9
fix(html): add k-sr-only span inside empty Pivotgrid cell
TeyaVes Nov 13, 2024
5dcd3c8
fix(html): update Pivotgrid chiplist class name in jQuery implementaion
TeyaVes Nov 13, 2024
05f18ca
fix(html): remove k-selectable class from Gantt
TeyaVes Nov 14, 2024
15b4adc
fix(html): add k-grid-aria-root to Treelist in Gantt
TeyaVes Nov 14, 2024
d8ee156
chore(html): simplify Gantt templates
TeyaVes Nov 14, 2024
7ffdead
fix(splitter): add touch-action: none style to splitbar
TeyaVes Nov 20, 2024
8698ed7
chore: update visual previews
kendo-bot Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/default/scss/splitter/_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
outline: 0;
position: absolute;
user-select: none;
touch-action: none;
display: flex;
align-items: center;
justify-content: center;
Expand Down
1 change: 1 addition & 0 deletions packages/fluent/scss/splitter/_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
outline: 0;
position: absolute;
user-select: none;
touch-action: none;
display: flex;
align-items: center;
justify-content: center;
Expand Down
544 changes: 4 additions & 540 deletions packages/html/src/gantt/templates/gantt-normal.tsx
View file
Open in desktop

Large diffs are not rendered by default.

562 changes: 4 additions & 558 deletions packages/html/src/gantt/templates/gantt-row-reordering.tsx
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/html/src/pivotgrid/pivotgrid.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ export type KendoPivotGridProps = {
};

const defaultOptions = {
emptyCell: <span className="k-pivotgrid-empty-cell" />,
emptyCell: <span className="k-pivotgrid-empty-cell">
<span className="k-sr-only">PivotGrid component. Use the arrow keys to navigate.</span>
</span>,
configuratorDisplay: "none",
configuratorPosition: "right"
};
Expand Down
4 changes: 3 additions & 1 deletion packages/html/src/pivotgrid/tests/pivotgrid-cell-states.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ export default () => (
<section>
<PivotGridNormal
emptyCell={
<span className="k-pivotgrid-empty-cell k-focus" />
<span className="k-pivotgrid-empty-cell k-focus">
<span className="k-sr-only">PivotGrid component. Use the arrow keys to navigate.</span>
</span>
}
rowHeaders={
<PivotGridTable>
Expand Down
18 changes: 17 additions & 1 deletion packages/html/src/toolbar/toolbar.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Button } from '../button';
import { Button, IconButton, IconTextButton } from '../button';
import { ButtonGroup } from '../button-group';
import { ColorPicker } from '../colorpicker';
import { Combobox } from '../combobox';
Expand Down Expand Up @@ -68,6 +68,22 @@ export const Toolbar = (
className={`k-toolbar-button ${child.props.className ? child.props.className : ''}`}
></Button>
);
} else if (child.type === IconTextButton) {
tempToolbarChildren.push(
<IconTextButton
key={`${index}-${new Date().getTime()}`}
{...child.props}
className={`k-toolbar-button ${child.props.className ? child.props.className : ''}`}
></IconTextButton>
);
} else if (child.type === IconButton) {
tempToolbarChildren.push(
<IconButton
key={`${index}-${new Date().getTime()}`}
{...child.props}
className={`k-toolbar-button ${child.props.className ? child.props.className : ''}`}
></IconButton>
);
} else if (child.type === MenuButton) {
tempToolbarChildren.push(
<MenuButton
Expand Down
Binary file modified tests/_output/bootstrap/gantt/gantt-row-reordering.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/bootstrap/gantt/gantt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/classic/gantt/gantt-row-reordering.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/classic/gantt/gantt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/default/gantt/gantt-row-reordering.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/default/gantt/gantt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/fluent/gantt/gantt-row-reordering.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/fluent/gantt/gantt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/material/gantt/gantt-row-reordering.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/material/gantt/gantt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1,476 changes: 211 additions & 1,265 deletions tests/gantt/gantt-row-reordering.html
View file
Open in desktop

Large diffs are not rendered by default.

1,274 changes: 173 additions & 1,101 deletions tests/gantt/gantt.html
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion tests/pivotgrid/pivotgrid-cell-states.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
<section>
<div class="k-d-flex k-flex-row k-pos-relative">
<div class="k-pivotgrid" style="grid-template-rows: 111px 1fr; grid-template-columns: 369px 1fr;">
<span class="k-pivotgrid-empty-cell k-focus"></span>
<span class="k-pivotgrid-empty-cell k-focus">
<span class="k-sr-only">PivotGrid component. Use the arrow keys to navigate.</span>
</span>
<div class="k-pivotgrid-column-headers">
<table class="k-pivotgrid-table">
<colgroup>
Expand Down
8 changes: 6 additions & 2 deletions tests/pivotgrid/pivotgrid-settings-left-right.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
<section>
<div class="k-d-flex k-flex-row-reverse k-pos-relative">
<div class="k-pivotgrid" style="grid-template-rows: 111px 1fr; grid-template-columns: 369px 1fr;">
<span class="k-pivotgrid-empty-cell"></span>
<span class="k-pivotgrid-empty-cell">
<span class="k-sr-only">PivotGrid component. Use the arrow keys to navigate.</span>
</span>
<div class="k-pivotgrid-column-headers">
<table class="k-pivotgrid-table">
<colgroup>
Expand Down Expand Up @@ -455,7 +457,9 @@
<section>
<div class="k-d-flex k-flex-row k-pos-relative">
<div class="k-pivotgrid" style="grid-template-rows: 111px 1fr; grid-template-columns: 369px 1fr;">
<span class="k-pivotgrid-empty-cell"></span>
<span class="k-pivotgrid-empty-cell">
<span class="k-sr-only">PivotGrid component. Use the arrow keys to navigate.</span>
</span>
<div class="k-pivotgrid-column-headers">
<table class="k-pivotgrid-table">
<colgroup>
Expand Down
4 changes: 3 additions & 1 deletion tests/pivotgrid/pivotgrid-settings-top.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
<section>
<div class="k-d-flex k-flex-col-reverse k-pos-relative">
<div class="k-pivotgrid" style="height: 550px; grid-template-columns: 150px auto; grid-template-rows: 242px auto;">
<span class="k-pivotgrid-empty-cell"></span>
<span class="k-pivotgrid-empty-cell">
<span class="k-sr-only">PivotGrid component. Use the arrow keys to navigate.</span>
</span>
<div class="k-pivotgrid-column-headers">
<table class="k-pivotgrid-table">
<colgroup>
Expand Down
4 changes: 3 additions & 1 deletion tests/pivotgrid/pivotgrid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
<section>
<div class="k-d-flex k-flex-row k-pos-relative">
<div class="k-pivotgrid" style="height: 550px; grid-template-columns: 150px auto; grid-template-rows: 242px auto;">
<span class="k-pivotgrid-empty-cell"></span>
<span class="k-pivotgrid-empty-cell">
<span class="k-sr-only">PivotGrid component. Use the arrow keys to navigate.</span>
</span>
<div class="k-pivotgrid-column-headers">
<table class="k-pivotgrid-table">
<colgroup>
Expand Down
6 changes: 3 additions & 3 deletions tests/prompt/prompt-more-actions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,23 +28,23 @@
<div class="k-prompt">
<div class="k-prompt-header">
<div class="k-toolbar k-toolbar-md k-toolbar-flat">
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-sparkles">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="m320 32 54.3 137.7L512 224l-137.7 54.3L320 416l-54.3-137.7L128 224l137.7-54.3zM94 350 0 384l94 34 34 94 34-94 94-34-94-34-34-94zM70.6 70.6 0 96l70.5 25.5L96 192l25.5-70.5L192 96l-70.5-25.5L96 0 70.5 70.5Z"></path>
</svg>
</span>
<span class="k-button-text">Ask AI</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-comment">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M448 32H64c-17.6 0-32 14.4-32 32v416l96-96h320c17.6 0 32-14.4 32-32V64c0-17.6-14.4-32-32-32m0 319.942a1 1 0 0 1-.058.058H114.745L64 402.745V64.057a1 1 0 0 1 .057-.057h383.885q.031.027.058.057z"></path>
</svg>
</span>
<span class="k-button-text">Output</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected k-icon-button">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected k-icon-button">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-more-horizontal">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M128 240c0-26.4-21.6-48-48-48s-48 21.6-48 48 21.6 48 48 48 48-21.6 48-48m64 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48m160 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48"></path>
Expand Down
18 changes: 9 additions & 9 deletions tests/prompt/prompt-normal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,23 +27,23 @@
<div class="k-prompt">
<div class="k-prompt-header">
<div class="k-toolbar k-toolbar-md k-toolbar-flat">
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-sparkles">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="m320 32 54.3 137.7L512 224l-137.7 54.3L320 416l-54.3-137.7L128 224l137.7-54.3zM94 350 0 384l94 34 34 94 34-94 94-34-94-34-34-94zM70.6 70.6 0 96l70.5 25.5L96 192l25.5-70.5L192 96l-70.5-25.5L96 0 70.5 70.5Z"></path>
</svg>
</span>
<span class="k-button-text">Ask AI</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-comment">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M448 32H64c-17.6 0-32 14.4-32 32v416l96-96h320c17.6 0 32-14.4 32-32V64c0-17.6-14.4-32-32-32m0 319.942a1 1 0 0 1-.058.058H114.745L64 402.745V64.057a1 1 0 0 1 .057-.057h383.885q.031.027.058.057z"></path>
</svg>
</span>
<span class="k-button-text">Output</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-icon-button">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-icon-button">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-more-horizontal">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M128 240c0-26.4-21.6-48-48-48s-48 21.6-48 48 21.6 48 48 48 48-21.6 48-48m64 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48m160 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48"></path>
Expand Down Expand Up @@ -83,23 +83,23 @@
<div class="k-prompt">
<div class="k-prompt-header">
<div class="k-toolbar k-toolbar-md k-toolbar-flat">
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-sparkles">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="m320 32 54.3 137.7L512 224l-137.7 54.3L320 416l-54.3-137.7L128 224l137.7-54.3zM94 350 0 384l94 34 34 94 34-94 94-34-94-34-34-94zM70.6 70.6 0 96l70.5 25.5L96 192l25.5-70.5L192 96l-70.5-25.5L96 0 70.5 70.5Z"></path>
</svg>
</span>
<span class="k-button-text">Ask AI</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-comment">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M448 32H64c-17.6 0-32 14.4-32 32v416l96-96h320c17.6 0 32-14.4 32-32V64c0-17.6-14.4-32-32-32m0 319.942a1 1 0 0 1-.058.058H114.745L64 402.745V64.057a1 1 0 0 1 .057-.057h383.885q.031.027.058.057z"></path>
</svg>
</span>
<span class="k-button-text">Output</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-icon-button">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-icon-button">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-more-horizontal">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M128 240c0-26.4-21.6-48-48-48s-48 21.6-48 48 21.6 48 48 48 48-21.6 48-48m64 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48m160 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48"></path>
Expand Down Expand Up @@ -154,23 +154,23 @@
<div class="k-prompt">
<div class="k-prompt-header">
<div class="k-toolbar k-toolbar-md k-toolbar-flat">
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-selected">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-sparkles">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="m320 32 54.3 137.7L512 224l-137.7 54.3L320 416l-54.3-137.7L128 224l137.7-54.3zM94 350 0 384l94 34 34 94 34-94 94-34-94-34-34-94zM70.6 70.6 0 96l70.5 25.5L96 192l25.5-70.5L192 96l-70.5-25.5L96 0 70.5 70.5Z"></path>
</svg>
</span>
<span class="k-button-text">Ask AI</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-comment">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M448 32H64c-17.6 0-32 14.4-32 32v416l96-96h320c17.6 0 32-14.4 32-32V64c0-17.6-14.4-32-32-32m0 319.942a1 1 0 0 1-.058.058H114.745L64 402.745V64.057a1 1 0 0 1 .057-.057h383.885q.031.027.058.057z"></path>
</svg>
</span>
<span class="k-button-text">Output</span>
</button>
<button class="k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-icon-button">
<button class="k-toolbar-button k-button k-button-md k-button-flat k-button-flat-primary k-rounded-full k-icon-button">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-more-horizontal">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M128 240c0-26.4-21.6-48-48-48s-48 21.6-48 48 21.6 48 48 48 48-21.6 48-48m64 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48m160 0c0 26.4 21.6 48 48 48s48-21.6 48-48-21.6-48-48-48-48 21.6-48 48"></path>
Expand Down
Loading