add StackLayout and GridLayout component modules #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhpenkov
force-pushed
the
stack-grid-layout-modules
branch
from
8c3d630
to
a203449
Compare
inikolova
reviewed
Nov 12, 2024
inikolova
reviewed
Nov 12, 2024
epetrow
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Just a few thoughts:
- I think it would be a good practice for any new component to be forwarded last in the
index.scss, this way we will ensure that all dependencies (if any) are loaded. This is a general suggestion and does not directly apply to this PR. - Adding the missing icon in Bootstrap is a fix
zhpenkov
force-pushed
the
stack-grid-layout-modules
branch
from
a203449
to
8a2ddbc
Compare
zhpenkov
force-pushed
the
stack-grid-layout-modules
branch
from
8a2ddbc
to
4d0de89
Compare
epetrow
approved these changes
Nov 18, 2024
inikolova
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sass component modules for the GridLayout & StackLayout components.