[WIP] HTML Templates snapshots/markup #5093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhpenkov
force-pushed
the
templates-snapshots
branch
4 times, most recently
from
4a9980e
to
56e172f
Compare
zhpenkov
force-pushed
the
templates-snapshots
branch
from
da1d984
to
8732bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: https://github.com/telerik/kendo-themes-private/issues/197
This PR adds the ability to access templates in the dev server.
And provides an automatic way to generate HTML and Snapshots for templates.
How to access templates on the dev server?
After navigating to
http://localhost:3000/packages/html/dist/{component},there are now two component subfolders to choose from:
templates- opens the templates of the componenttests- opens the tests of the component (as it was before)Upon selecting a certain template/test of a component, it will be loaded on the page.
How are HTML outputs and Snaphots generated?
On push, a workflow is triggered that detects changes in the generated HTML and screenshots for the templates.
If a difference is present or a new file is created, the
chore: update visual previewscommits the differences/additions.The generated HTML is held in the
templates/folder on a root level of thekendo-themes.The generated screenshots are held in the
templates/_output/{theme}folders (same structure astests/).