-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to filter message searches by channel sender in groups #25104
Open
TheWug
wants to merge
6
commits into
telegramdesktop:dev
Choose a base branch
from
TheWug:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can send messages as channels in any supergroup which either has a public username or is linked to a channel. Previously it was not possible to filter by sender for messages sent on behalf of a channel, and now it is. In order to avoid confusion, you must search by the channel's exact username, and the group must permit sending messages as channels. It is worth considering whether chat administrators should always be able to search for messages by any channel, regardless of group or channel settings, to ensure they can handle adversarial situations.
Wug seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
23rd
reviewed
Sep 21, 2022
23rd
reviewed
Sep 21, 2022
23rd
reviewed
Sep 21, 2022
23rd
reviewed
Sep 21, 2022
23rd
reviewed
Sep 21, 2022
Co-authored-by: 23rd <[email protected]>
Co-authored-by: 23rd <[email protected]>
Co-authored-by: 23rd <[email protected]>
Co-authored-by: 23rd <[email protected]>
Co-authored-by: 23rd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can send messages as channels in any supergroup which either has a public username or is linked to a channel. Previously it was not possible to filter by sender for messages sent on behalf of a channel, and now it is. In order to avoid confusion, you must search by the channel's exact username, and the group must permit sending messages as channels.
It is worth considering whether chat administrators should always be able to search for messages by any channel, regardless of group or channel settings, to ensure they can handle adversarial situations, but this pull request addresses only the simple case.
closes #25105