-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pipelines.md #624
base: main
Are you sure you want to change the base?
Update pipelines.md #624
Conversation
The committers listed above are authorized under a signed CLA. |
/retest |
@prad9192: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @lucperkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prad9192, thanks for the PR. Can you please clarify why this change is required?
I reviewed the getting started guide and default
does appear to be the correct value here.
If you've updated your context to point to a different namespace that could explain why you had to modify the command.
I would perhaps suggest instead of changing default
to tekton-pipelines
here, we should add -n default
to the kubectl apply
commands to ensure the resources are created in the expected namespace regardless of the user's local config.
Typically you would not want to deploy additional resources into the tekton-pipelines
namespace as it is reserved for the Tekton services themselves.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating the Getting started with Pipelines documentation