Remove references to gcr.io/tekton* #2339
Conversation
tekton-robot
added
the
kind/misc
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
scripts/library.sh
Outdated
| # Return whether the given parameter is the tekton release/nightly GCF. | ||
| # Parameters: $1 - full GCR name, e.g. gcr.io/tekton-foo-bar |
There was a problem hiding this comment.
nit: comment should be updated to refer to GHCR too
| @@ -101,7 +101,7 @@ spec: | |||
| - name: SINK_URL | |||
| value: "sink-url" | |||
| - name: TARGET_IMAGE | |||
| value: "gcr.io/tekton-releases/dogfooding/myimage" | |||
| value: "ghcr.io/tekton-releases/dogfooding/myimage" | |||
There was a problem hiding this comment.
Should these references be updated to ghcr.io/tektoncd/plumbing/… to avoid confusion?
There are a bunch of other references to tekton-releases which are no longer valid as far as I understand.
Similar for references to tekton-nightly which I think is no longer used, as the nightly releases are no longer namespaced separately.
| @@ -255,7 +255,7 @@ metadata: | |||
| --- | |||
| apiVersion: v1 | |||
| data: | |||
| image: gcr.io/k8s-prow/entrypoint@sha256:7c7cd8906ce4982ffee326218e9fc75da2d4896d53cabc9833b9cc8d2d6b2b8f | |||
| image: ghcr.io/k8s-prow/entrypoint@sha256:7c7cd8906ce4982ffee326218e9fc75da2d4896d53cabc9833b9cc8d2d6b2b8f | |||
There was a problem hiding this comment.
Should this be reverted? Not an image we control and doesn't appear to be available on GHCR
There was a problem hiding this comment.
Yes, I will revert that... it's just a test file for koparse though, so it could be foo.bar and still work :D
Cleanup the remaining refences to tekton-* projects under gcr.io from resources and docs. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
cleanup_gcr_tekton
branch
from
f64bb42 to
02a7340
Compare
tekton-robot
added
size/M
Changes
Cleanup the remaining refences to tekton-* projects under gcr.io from resources and docs.
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.