Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-feature Flag Test Suite #7627

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 31, 2024

Changes

Now that we have more per-feature flags in place, this PR adds the
per feature flag test. It currently utilize minimum end-to-end tests for
stable features while mocking stable, beta and alpha stability with
different test envs.

Currently this runs ~ 970s for my local env with 4 per-feature flags,
which is a reasonable amount since we are likely to be able to have a max
of ~ 12 flags within the timeframe of 60mins.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 31, 2024
@JeromeJu JeromeJu added this to the Pipelines v0.57 milestone Feb 1, 2024
@chitrangpatel
Copy link
Contributor

Thanks for this @JeromeJu !

Looks good to me.

Is there a plan to run this as part of our CI?
Since it only takes ~15 mins, I think we should.

@chitrangpatel
Copy link
Contributor

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@JeromeJu
Copy link
Member Author

JeromeJu commented Feb 6, 2024

Thanks for this @JeromeJu !

Looks good to me.

Is there a plan to run this as part of our CI? Since it only takes ~15 mins, I think we should.

Thanks Chitrang for the review.

Per discussion at tektoncd/plumbing#1629 (comment), let's have this in nightly first while we had some concern mentioned earlier. We could move it to be part of the per-build CI once we are actually having more per-feature flags(as the possibility of inter-correlation increases) and the nightly are proven to be effective.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2024
@JeromeJu JeromeJu force-pushed the tep0138-per-feature-flag branch from 7588c2a to 4e458a8 Compare February 8, 2024 14:44
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2024
@JeromeJu
Copy link
Member Author

JeromeJu commented Feb 8, 2024

cc @tektoncd/core-maintainers can I have a lgtm for this change please?

This commit releases the per feature flag test. It currently utilize
minimum end-to-end tests for stable features while mocking stable, beta
and alpha stability with different test envs.

/kind misc
@JeromeJu JeromeJu force-pushed the tep0138-per-feature-flag branch from 4e458a8 to 3728063 Compare February 8, 2024 17:22
@JeromeJu
Copy link
Member Author

JeromeJu commented Feb 8, 2024

/test pull-tekton-pipeline-beta-integration-tests

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@tekton-robot tekton-robot merged commit 0cf8d03 into tektoncd:main Feb 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants