Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0142: Surface step results via sidecar logs #7414

Merged
merged 1 commit into from
Nov 24, 2023
Merged

TEP-0142: Surface step results via sidecar logs #7414

merged 1 commit into from
Nov 24, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Nov 23, 2023 •
edited
Loading

Prior to this, we enabled surfacing Step Results via termination-message. This PR does the same thing for sidecar-logs. It would ensure that we can use StepResults when results-from: sidecar-logs feature flag is enabled.

This PR is part of issue #7259.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Surface step results via sidecar logs

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 23, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 23, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.6% 0.3
pkg/entrypoint/entrypointer.go 87.6% 87.0% -0.6
pkg/pod/entrypoint.go 93.4% 94.1% 0.7
pkg/pod/pod.go 92.7% 90.2% -2.4
pkg/pod/status.go 91.7% 90.7% -1.0
pkg/reconciler/taskrun/resources/apply.go 99.3% 99.4% 0.0
pkg/result/result.go 85.7% 86.7% 1.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.6% 0.3
pkg/entrypoint/entrypointer.go 87.6% 87.0% -0.6
pkg/pod/entrypoint.go 93.4% 94.1% 0.7
pkg/pod/pod.go 92.7% 90.2% -2.4
pkg/pod/status.go 91.7% 90.7% -1.0
pkg/reconciler/taskrun/resources/apply.go 99.3% 99.4% 0.0
pkg/result/result.go 85.7% 86.7% 1.0

@chitrangpatel chitrangpatel marked this pull request as draft November 23, 2023 17:47
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2023
@chitrangpatel chitrangpatel mentioned this pull request Nov 23, 2023
Closed
20 tasks
@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 0cd5f90 to 8349b82 Compare November 23, 2023 18:43
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 23, 2023
@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 8349b82 to ed4d578 Compare November 23, 2023 18:45
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 92.7% 90.2% -2.4
pkg/pod/status.go 92.1% 90.7% -1.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 92.7% 90.2% -2.4
pkg/pod/status.go 92.1% 90.7% -1.4

@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from ed4d578 to 071bb40 Compare November 23, 2023 19:46
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 93.1% 1.0

@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 071bb40 to 4702d23 Compare November 23, 2023 20:23
@chitrangpatel chitrangpatel marked this pull request as ready for review November 23, 2023 20:23
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.4% 1.4
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 93.1% 1.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.4% 1.4
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 93.1% 1.0

@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 4702d23 to cb14e57 Compare November 23, 2023 20:47
@QuanZhang-William
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from cb14e57 to b099f62 Compare November 23, 2023 21:13
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
Yongxuanzhang
Yongxuanzhang approved these changes Nov 23, 2023
View reviewed changes
pkg/pod/pod.go Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from b099f62 to 0fcca32 Compare November 23, 2023 21:29
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@chitrangpatel
TEP-0142: Surface step results via sidecar logs
cbd3850 
Prior to this, we enabled surfacing step results via termination message. This PR does the same thing via sidecar logs.
@chitrangpatel chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 0fcca32 to cbd3850 Compare November 23, 2023 21:49
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 88.0% 89.6% 1.6
pkg/pod/pod.go 92.7% 92.2% -0.5
pkg/pod/status.go 92.1% 92.9% 0.8

@QuanZhang-William
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@tekton-robot tekton-robot merged commit 30540fc into tektoncd:main Nov 24, 2023
13 checks passed
@ericzzzzzzz ericzzzzzzz mentioned this pull request Apr 22, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@jerop jerop Awaiting requested review from jerop

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

@QuanZhang-William QuanZhang-William Awaiting requested review from QuanZhang-William

Assignees

@QuanZhang-William QuanZhang-William

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chitrangpatel @tekton-robot @QuanZhang-William @Yongxuanzhang