Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0142: Introduce Value in TaskResults #7347

Merged
merged 1 commit into from
Nov 10, 2023
Merged

TEP-0142: Introduce Value in TaskResults #7347

merged 1 commit into from
Nov 10, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Nov 10, 2023 •
edited
Loading

This PR introduces the field Value in TaskResults. This field is necessary to capture the results produced by StepActions if the Task needs to resolve name conflicts.

This is part of issue #7259. Following this PR, we will add support for extracting StepAction results via termination message and sidecar logs.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] StepActions: Introduce Value in TaskResults

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2023
@chitrangpatel chitrangpatel requested review from Yongxuanzhang and jerop and removed request for abayer and bobcatfish November 10, 2023 04:21
@chitrangpatel chitrangpatel mentioned this pull request Nov 10, 2023
Closed
20 tasks
@chitrangpatel chitrangpatel force-pushed the step-action-results-syntax branch from 37ff8ec to 9aea50f Compare November 10, 2023 04:27
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/result_defaults.go 100.0% 90.9% -9.1
pkg/apis/pipeline/v1beta1/result_defaults.go 100.0% 90.9% -9.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/result_defaults.go 100.0% 90.9% -9.1
pkg/apis/pipeline/v1beta1/result_defaults.go 100.0% 90.9% -9.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/result_defaults.go 100.0% 90.9% -9.1
pkg/apis/pipeline/v1beta1/result_defaults.go 100.0% 90.9% -9.1

@chitrangpatel chitrangpatel marked this pull request as draft November 10, 2023 05:14
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2023
@chitrangpatel chitrangpatel force-pushed the step-action-results-syntax branch from 9aea50f to 0ec4fec Compare November 10, 2023 15:47
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2023
@chitrangpatel chitrangpatel marked this pull request as ready for review November 10, 2023 15:47
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2023
@chitrangpatel chitrangpatel force-pushed the step-action-results-syntax branch from 0ec4fec to bd859fd Compare November 10, 2023 16:11
Yongxuanzhang
Yongxuanzhang approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor comments, questions

pkg/apis/pipeline/v1/result_validation.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/result_validation.go Show resolved Hide resolved
pkg/apis/pipeline/v1/result_validation_test.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/result_validation.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/result_validation_test.go Show resolved Hide resolved
pkg/apis/pipeline/v1/result_validation.go Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@Yongxuanzhang
Copy link
Member

Yongxuanzhang commented Nov 10, 2023 •
edited
Loading

I think we need to fix alpha integration tests. It's because we enable step action for all alpha tests. And the tests are asserting the resolved results. But we are adding default string type for them

@chitrangpatel chitrangpatel force-pushed the step-action-results-syntax branch from bd859fd to caeda0c Compare November 10, 2023 17:07
@tekton-robot tekton-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 10, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2023
@jerop jerop added this to the Pipelines v0.54 milestone Nov 10, 2023
@chitrangpatel
Introduce Value in TaskResults
54bda50 
This PR introduces the field `Value` in `TaskResults`.
This field is necessary to capture the results produced by `StepActions`
if the Task needs to resolve name conflicts.

This is part of issue tektoncd#7259.
Following this PR, we will add support for extracting StepAction results
via termination message and sidecar logs.
@chitrangpatel chitrangpatel force-pushed the step-action-results-syntax branch from caeda0c to 54bda50 Compare November 10, 2023 20:27
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2023
@chitrangpatel chitrangpatel changed the title Introduce Value in TaskResults TEP-0142: Introduce Value in TaskResults Nov 10, 2023
@chitrangpatel chitrangpatel mentioned this pull request Nov 10, 2023
Merged
7 tasks
jerop
jerop reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@tekton-robot tekton-robot merged commit f975869 into tektoncd:main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@jerop jerop jerop left review comments

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.
4 participants
@chitrangpatel @tekton-robot @Yongxuanzhang @jerop