Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0142] Add VolumeMounts to StepAction #7340

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[TEP-0142] Add VolumeMounts to StepAction #7340

merged 1 commit into from
Nov 9, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Nov 7, 2023 •
edited
Loading

Changes

Part of #7259. This commit adds VolumeMounts to StepAction, the VolumeMount.Name should use string param reference, and cannot be set both with Step from Task/TaskRun.

/kind feature

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] Users can define VolumeMounts in StepAction, the VolumeMounts Name should use string param reference to the params passed to the StepAction.

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2023
@Yongxuanzhang Yongxuanzhang mentioned this pull request Nov 7, 2023
Closed
20 tasks
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Nov 7, 2023
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review November 7, 2023 21:58
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
@Yongxuanzhang
Copy link
Member Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@Yongxuanzhang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2023
chitrangpatel
chitrangpatel reviewed Nov 8, 2023
View reviewed changes
docs/stepactions.md Outdated Show resolved Hide resolved
@chitrangpatel
Copy link
Contributor

Please add [WIP] to your release notes.

@Yongxuanzhang
Copy link
Member Author

Yongxuanzhang commented Nov 8, 2023 •
edited by chitrangpatel
Loading

Please add [WIP] to your release notes.

Thanks, added. Is it because the param replacements are not supported yet?

Yes, Params and Results are still critical pieces missing from StepActions in general. Once we add all the pieces, I will put out a final release note with how they can enable it and start using it as an alpha feature.

@Yongxuanzhang Yongxuanzhang force-pushed the stepaction-volumeamounts branch from 2814cf7 to d6f8600 Compare November 8, 2023 16:19
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@chitrangpatel
Copy link
Contributor

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@jerop
Copy link
Member

jerop commented Nov 8, 2023

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look 🙏🏾

jerop
jerop reviewed Nov 8, 2023
View reviewed changes
docs/stepactions.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@jerop jerop added this to the Pipelines v0.54 milestone Nov 9, 2023
@Yongxuanzhang Yongxuanzhang force-pushed the stepaction-volumeamounts branch from d6f8600 to ecdcb4d Compare November 9, 2023 15:49
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@Yongxuanzhang Yongxuanzhang force-pushed the stepaction-volumeamounts branch from ecdcb4d to 699b93c Compare November 9, 2023 15:57
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@Yongxuanzhang Yongxuanzhang requested a review from jerop November 9, 2023 16:16
jerop
jerop reviewed Nov 9, 2023
View reviewed changes
docs/stepactions.md Outdated Show resolved Hide resolved
@Yongxuanzhang
[TEP-0142] Add VolumeMounts to StepAction
c1b6abc 
This commit adds VolumeMounts to StepAction, the VolumeMount.Name should
use string param reference, and cannot be set both with Step from
Task/TaskRun.

Signed-off-by: Yongxuan Zhang [email protected]
@Yongxuanzhang Yongxuanzhang force-pushed the stepaction-volumeamounts branch from 935d555 to c1b6abc Compare November 9, 2023 16:26
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1alpha1/stepaction_validation.go 98.7% 99.0% 0.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0
pkg/substitution/substitution.go 87.0% 87.0% 0.0

@jerop
Copy link
Member

jerop commented Nov 9, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@tekton-robot tekton-robot merged commit f08add9 into tektoncd:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@chitrangpatel chitrangpatel chitrangpatel left review comments

@vdemeester vdemeester Awaiting requested review from vdemeester

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.
4 participants
@Yongxuanzhang @tekton-robot @chitrangpatel @jerop