TEP-0142: Referencing StepActions in Steps #7271

chitrangpatel · 2023-10-24T22:38:19Z

This PR allows the Step to reference a StepAction CRD deployed on the cluster. This capability is gated behind a feature flag enable-step-actions. Remote resolution of StepActions will be implemented in a follow-up PR.

This is the fourth item on the implementation Issue #7259

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] Enables referencing of StepActions in Steps if the feature flag "enable-step-actions: true" is set.

/kind feature

tekton-robot · 2023-10-24T22:46:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	90.1%	-1.7
pkg/reconciler/taskrun/resources/taskspec.go	100.0%	92.3%	-7.7
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-24T22:49:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	90.1%	-1.7
pkg/reconciler/taskrun/resources/taskspec.go	100.0%	92.3%	-7.7
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

chitrangpatel · 2023-10-25T00:54:47Z

@jerop I assume we also want to allow referencing via v1beta1 api and have conversion functions between v1 and v1beta1?

tekton-robot · 2023-10-25T14:44:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/container_conversion.go	100.0%	94.7%	-5.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	90.1%	-1.7
pkg/reconciler/taskrun/resources/taskspec.go	100.0%	92.3%	-7.7
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T14:50:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/container_conversion.go	100.0%	94.7%	-5.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	90.1%	-1.7
pkg/reconciler/taskrun/resources/taskspec.go	100.0%	92.3%	-7.7
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T15:41:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/container_conversion.go	100.0%	94.7%	-5.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T15:43:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/container_conversion.go	100.0%	94.7%	-5.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T15:56:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/container_conversion.go	100.0%	94.7%	-5.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T15:57:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/container_conversion.go	100.0%	94.7%	-5.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T16:00:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/container_conversion.go	100.0%	94.7%	-5.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T16:23:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T16:25:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T16:57:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-25T16:58:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	94.0%	94.1%	0.1
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

chitrangpatel · 2023-10-25T17:22:23Z

/hold wait for PR #7284 to get merged

chitrangpatel · 2023-10-27T14:28:12Z

/hold cancel

tekton-robot · 2023-10-27T14:36:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-27T14:41:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-27T14:42:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

jerop · 2023-10-27T15:42:47Z

@tektoncd/core-maintainers this is ready for review, ptal 🙏🏾

pkg/reconciler/taskrun/resources/taskspec.go

pkg/reconciler/taskrun/resources/taskspec_test.go

pkg/reconciler/taskrun/resources/taskspec.go

pkg/reconciler/taskrun/resources/taskspec_test.go

tekton-robot · 2023-10-27T17:09:04Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-27T17:10:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

pkg/reconciler/taskrun/taskrun_test.go

pkg/reconciler/taskrun/resources/taskref.go

Yongxuanzhang

Thanks for the work!

pkg/reconciler/taskrun/resources/taskref.go

pkg/reconciler/taskrun/resources/taskref_test.go

This PR allows the Step to reference a StepAction CRD deployed on the cluster. This capability is gated behind a feature flag `enable-step-actions`. Remote resolution of StepActions will be implemented in a follow-up PR. This is the second item on the implementation Issue tektoncd#7259

tekton-robot · 2023-10-30T13:08:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

tekton-robot · 2023-10-30T13:09:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	91.8%	92.6%	0.8
pkg/reconciler/taskrun/taskrun.go	85.1%	85.4%	0.3
test/controller.go	30.7%	29.5%	-1.2

jerop

🎉

thank you @chitrangpatel

tekton-robot · 2023-10-30T13:45:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Yongxuanzhang,jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop · 2023-10-30T13:46:58Z

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look 🙏🏾

jerop

/lgtm

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 24, 2023

tekton-robot requested review from abayer and jerop October 24, 2023 22:38

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 24, 2023

chitrangpatel force-pushed the enable-step-actions branch from 0cdff32 to 9ead681 Compare October 25, 2023 14:35

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 25, 2023

chitrangpatel force-pushed the enable-step-actions branch from 9ead681 to 4f441bb Compare October 25, 2023 15:35

chitrangpatel force-pushed the enable-step-actions branch 2 times, most recently from 1e503bb to c9e4eda Compare October 25, 2023 15:51

chitrangpatel force-pushed the enable-step-actions branch from c9e4eda to e99e171 Compare October 25, 2023 16:17

chitrangpatel force-pushed the enable-step-actions branch from e99e171 to dd66156 Compare October 25, 2023 16:50

chitrangpatel mentioned this pull request Oct 25, 2023

TEP-0142: Enable Step Reusability - Implementation #7259

Closed

20 tasks

chitrangpatel force-pushed the enable-step-actions branch from dd66156 to 2533c02 Compare October 25, 2023 17:21

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2023

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2023

chitrangpatel force-pushed the enable-step-actions branch from 1f59118 to ae6e32f Compare October 27, 2023 14:32

jerop self-assigned this Oct 27, 2023

Yongxuanzhang reviewed Oct 27, 2023

View reviewed changes

chitrangpatel force-pushed the enable-step-actions branch from ae6e32f to 3ba35ca Compare October 27, 2023 17:01

chitrangpatel requested a review from Yongxuanzhang October 27, 2023 17:02

Yongxuanzhang reviewed Oct 27, 2023

View reviewed changes

pkg/reconciler/taskrun/taskrun_test.go Outdated Show resolved Hide resolved

Yongxuanzhang reviewed Oct 27, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/taskref.go Show resolved Hide resolved

Yongxuanzhang approved these changes Oct 27, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/taskref.go Outdated Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023

jerop reviewed Oct 27, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/taskref.go Outdated Show resolved Hide resolved

pkg/reconciler/taskrun/resources/taskref_test.go Outdated Show resolved Hide resolved

chitrangpatel force-pushed the enable-step-actions branch from 3ba35ca to ce4f08d Compare October 30, 2023 13:01

chitrangpatel requested a review from jerop October 30, 2023 13:02

jerop approved these changes Oct 30, 2023

View reviewed changes

jerop reviewed Oct 30, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023

tekton-robot merged commit 7069889 into tektoncd:main Oct 30, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP-0142: Referencing StepActions in Steps #7271

TEP-0142: Referencing StepActions in Steps #7271

chitrangpatel commented Oct 24, 2023 •

edited

Loading

tekton-robot commented Oct 24, 2023

tekton-robot commented Oct 24, 2023

chitrangpatel commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

chitrangpatel commented Oct 25, 2023 •

edited

Loading

chitrangpatel commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

jerop commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

Yongxuanzhang left a comment

tekton-robot commented Oct 30, 2023

tekton-robot commented Oct 30, 2023

jerop left a comment

tekton-robot commented Oct 30, 2023

jerop commented Oct 30, 2023

jerop left a comment

TEP-0142: Referencing StepActions in Steps #7271

TEP-0142: Referencing StepActions in Steps #7271

Conversation

chitrangpatel commented Oct 24, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Oct 24, 2023

tekton-robot commented Oct 24, 2023

chitrangpatel commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

chitrangpatel commented Oct 25, 2023 • edited Loading

chitrangpatel commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

jerop commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

tekton-robot commented Oct 27, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 30, 2023

tekton-robot commented Oct 30, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 30, 2023

jerop commented Oct 30, 2023

jerop left a comment

Choose a reason for hiding this comment

chitrangpatel commented Oct 24, 2023 •

edited

Loading

chitrangpatel commented Oct 25, 2023 •

edited

Loading