TEP-0142: Introducing the StepAction CRD #7260
Conversation
tekton-robot
added
release-note
tekton-robot
added
the
size/XXL
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
StepActionCRD
branch
from
3a8293c to
d944cbb
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
StepActionCRD
branch
from
d944cbb to
d2bcca9
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
approved
chitrangpatel
force-pushed
the
StepActionCRD
branch
from
d2bcca9 to
c5d154b
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
StepActionCRD
branch
from
c5d154b to
ef4a3bc
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
This PR introduces the StepAction CRD in `v1alpha1`. This is not the complete CRD. As we add support for `params`, `results` etc. we will introduce in follow-up PRs. It is the first of many implementation PRs as described in issue: tektoncd#7259
chitrangpatel
force-pushed
the
StepActionCRD
branch
from
ef4a3bc to
c838184
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
Sorry for being a bad cop here 🙏 As excited as this is (introducing a significant new concept in the project) did not follow the diversity requirements: The Tekton community promotes company diversity as a best practice for pull request. This means that, where possible, one of the reviewers of a pull request and the author should be affiliated to different organizations. This policy was introduced after a discussion at the Governance WG: /cc @tektoncd/core-maintainers |
Agreed! Let's not repeat the same mistake in the follow up PRs. |
|
We were just eager to review in a timely manner. We will keep an eye on that guidance going forward. Thank you for pointing it out @pritidesai! @pritidesai @tektoncd/core-maintainers if you have any feedback on this change, @chitrangpatel can address in a follow up PR. We would also appreciate any help in reviewing future PRs as soon as you can as we are targeting v0.54 release next month 🙏🏾 |
0.53 is not out yet and the focus right now is on one last pending PR 🙏 : https://github.com/tektoncd/pipeline/pulls?q=is%3Aopen+is%3Apr+milestone%3A%22Pipelines+v0.53+LTS%22 |
Thanks @pritidesai for the reminder, we should definitely follow the rules! |
That's right, but that one remaining PR has feedback from several maintainers who can merge it when feedback is addressed -- happy to take a look at that PR if it helps (but we need a non-Googler to review it at this point) Started reviewing this PR targeting v0.54 because this is a huge chunk of work split over many pull requests, so would like to get some head start to make it in time instead of rushing near the deadline - #7259 |
jerop
changed the title
This PR introduces the StepAction CRD in
v1alpha1. This is not the complete CRD. As we add support forparams,resultsetc. we will introduce them in follow-up PRs.It is the first of many implementation PRs as described in issue #7259.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind feature