Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard the field #7247

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard the field #7247

merged 1 commit into from
Oct 20, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Oct 19, 2023 •
edited
Loading

Changes

This commit is the 2nd PR of TEP-0145 tracking issue is #7244.

This commit adds CEL field to the WhenExpression, a feature flag enable-cel-in-whenexpression to guard the new api field.

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 19, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 19, 2023
@Yongxuanzhang
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2023
@Yongxuanzhang Yongxuanzhang mentioned this pull request Oct 19, 2023
Closed
5 tasks
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 93.0% -0.9
pkg/apis/pipeline/v1/when_validation.go 100.0% 62.5% -37.5
pkg/apis/pipeline/v1beta1/when_validation.go 100.0% 62.5% -37.5

@Yongxuanzhang
Copy link
Member Author

/test pull-tekton-pipeline-unit-tests

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review October 19, 2023 20:15
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.3% 95.4% 0.0

@tektoncd tektoncd deleted a comment from tekton-robot Oct 19, 2023
@tektoncd tektoncd deleted a comment from tekton-robot Oct 19, 2023
@tektoncd tektoncd deleted a comment from tekton-robot Oct 19, 2023
@tektoncd tektoncd deleted a comment from tekton-robot Oct 19, 2023
@tektoncd tektoncd deleted a comment from tekton-robot Oct 19, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.3% 95.4% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1/when_validation.go 100.0% 96.0% -4.0

@Yongxuanzhang Yongxuanzhang force-pushed the cel-tep-145-1 branch 2 times, most recently from 00f70fb to 145ba47 Compare October 19, 2023 20:51
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.3% 95.4% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.3% 95.4% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.3% 95.4% 0.0

@Yongxuanzhang Yongxuanzhang requested a review from jerop October 20, 2023 16:36
jerop
jerop reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yongxuanzhang thanks for breaking down the implementation

Can we please add incremental docs as well, so in this PR we can include docs for the API and feature flag -- and add a note that this is work in progress 🙏🏾

pkg/apis/pipeline/v1/when_types.go Show resolved Hide resolved
pkg/apis/pipeline/v1/when_validation_test.go Outdated Show resolved Hide resolved
@Yongxuanzhang
[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard…
e487bfb 
… the field

add cel to the WhenExpression, a feature flag
enable-cel-in-whenexpression to guard thie new api field.

Signed-off-by: Yongxuan Zhang [email protected]
@Yongxuanzhang Yongxuanzhang requested a review from jerop October 20, 2023 17:15
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.3% 95.4% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.9% 94.0% 0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.3% 95.4% 0.0

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@Yongxuanzhang
Copy link
Member Author

/retest

@Yongxuanzhang
Copy link
Member Author

The failing test: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/7247/pull-tekton-pipeline-alpha-integration-tests/1715445654538424320
was introduced in #7100, may be a new flaky test

@chitrangpatel
Copy link
Contributor

The failing test: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/7247/pull-tekton-pipeline-alpha-integration-tests/1715445654538424320
was introduced in #7100, may be a new flaky test

Yes, I think the content is there, just the ordering is different. This will be very flaky.
Screenshot 2023-10-20 at 4 16 59 PM

Fixing now. cc @chengjoey

@Yongxuanzhang
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 4026876 into tektoncd:main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@chitrangpatel chitrangpatel chitrangpatel left review comments

@afrittoli afrittoli Awaiting requested review from afrittoli

@vdemeester vdemeester Awaiting requested review from vdemeester

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yongxuanzhang @tekton-robot @chitrangpatel @jerop