Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6614 Add inclusive source scanning #7199

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

prestonvasquez
Copy link
Contributor

@prestonvasquez prestonvasquez commented Oct 11, 2023

Resolves #6614

Changes

Add inclusive terminology scan tool woke to the repository, including the woke-action workflow

Suggest using the configuration file here: https://github.com/canonical/Inclusive-naming/raw/main/config.yml. A configuration can be defined locally, if needed.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 11, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: prestonvasquez / name: Preston Vasquez (1a38e12)

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2023
@tekton-robot
Copy link
Collaborator

Hi @prestonvasquez. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2023
@prestonvasquez
Copy link
Contributor Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 11, 2023
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2023
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prestonvasquez the title of the PR shouldn't use TEP-6614 as there is no such TEP (stands for Tekton Enhancement Proposals, and the list is here). It's a bit confusing for maintainers to see that TEP when it refers to an issue 😝

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@vdemeester vdemeester changed the title TEP-6614 Add inclusive source scanning #6614 Add inclusive source scanning Oct 11, 2023
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prestonvasquez thanks for the contribution -- could you please squash the commits into one?

Use one commit per PR unless there is a strong reason not to ~ standards

.github/workflows/woke.yml Show resolved Hide resolved
@prestonvasquez
Copy link
Contributor Author

@prestonvasquez thanks for the contribution -- could you please squash the commits into one?

Use one commit per PR unless there is a strong reason not to ~ standards

@jerop I can definitely do that. However, GitHub has a "Squash and Merge" feature for pull requests. Is there a reason why we don't just do that?

@vdemeester
Copy link
Member

@prestonvasquez thanks for the contribution -- could you please squash the commits into one?
Use one commit per PR unless there is a strong reason not to ~ standards

@jerop I can definitely do that. However, GitHub has a "Squash and Merge" feature for pull requests. Is there a reason why we don't just do that?

Yes, the main reason for it is that is the "content" of the commit it generates. It will generate a commit with each commit message inlined. So if there is a "merge" commit in there, or some wip commit, etc.. the message will have little sense. The idea is more or less to make sure that all commits that get merged are well formatted and make sense (we do miss some from time to time that's sure). The UI of GitHub allows to "customize" the message when merging, but on this project (and in most big OSS project), we are never merging manually PR, it's a bot doing that, and the bot cannot really rephrase the squash commit. So that's why we only use the rebase and merge flow, and we usually require 1 commit per pull-request, except when there is a really strong case for multiple.

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@vdemeester
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@tekton-robot tekton-robot merged commit afd28ca into tektoncd:main Oct 26, 2023
2 checks passed
@afrittoli
Copy link
Member

The GitHub actions used here are not permitted by the current configuration - I will add them to the configuration now, but I'm concerned that this was merged without the job actually having been tested @vdemeester @Yongxuanzhang

@afrittoli
Copy link
Member

I got a successful run on #7356 now, so it's all fine.

@wlynch wlynch mentioned this pull request Nov 14, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inclusive source scanning
7 participants