-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6614 Add inclusive source scanning #7199
Conversation
|
Hi @prestonvasquez. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind misc |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prestonvasquez the title of the PR shouldn't use TEP-6614
as there is no such TEP (stands for Tekton Enhancement Proposals, and the list is here). It's a bit confusing for maintainers to see that TEP when it refers to an issue 😝
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prestonvasquez thanks for the contribution -- could you please squash the commits into one?
Use one commit per PR unless there is a strong reason not to
~ standards
@jerop I can definitely do that. However, GitHub has a "Squash and Merge" feature for pull requests. Is there a reason why we don't just do that? |
Yes, the main reason for it is that is the "content" of the commit it generates. It will generate a commit with each commit message inlined. So if there is a "merge" commit in there, or some |
a9da679
to
1a38e12
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The GitHub actions used here are not permitted by the current configuration - I will add them to the configuration now, but I'm concerned that this was merged without the job actually having been tested @vdemeester @Yongxuanzhang |
I got a successful run on #7356 now, so it's all fine. |
Resolves #6614
Changes
Add inclusive terminology scan tool woke to the repository, including the woke-action workflow
Suggest using the configuration file here: https://github.com/canonical/Inclusive-naming/raw/main/config.yml. A configuration can be defined locally, if needed.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes