Skip to content

Commit

Permalink
In DEVELOPMENT.md file , to configure upstream optional , while set u…
Browse files Browse the repository at this point in the history
…p a fork , the instructions throws an error when used in zsh shell , because of # symbol not found.

In setup cluster of type kind , the word kind is in Camel case Kind , changed it to lower case kind
The update or add new crd types in Iterating on code changes section, doesn't navigate and has been corrected.
  • Loading branch information
shankarpentyala07 authored and tekton-robot committed Oct 19, 2023
1 parent a2cf8d0 commit c52f937
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,11 @@ The Tekton project requires that you develop (commit) code changes to branches t
```shell
git remote add upstream [email protected]:tektoncd/pipeline.git
```
1. Optional: Prevent accidental pushing of commits by changing the upstream URL to `no_push`
# Optional: Prevent accidental pushing of commits by changing the upstream URL to `no_push`
```shell
git remote set-url --push upstream no_push
```
Expand Down Expand Up @@ -271,9 +274,9 @@ The recommended minimum development configuration is:
- 8 GB of (actual or virtualized) platform memory
- Node autoscaling, up to 3 nodes
#### Using [KinD](https://kind.sigs.k8s.io/)
#### Using [Kind](https://kind.sigs.k8s.io/)
[KinD](https://kind.sigs.k8s.io/) is a great tool for working with Kubernetes clusters locally. It is particularly useful to quickly test code against different cluster [configurations](https://kind.sigs.k8s.io/docs/user/quick-start/#advanced).
[Kind](https://kind.sigs.k8s.io/) is a great tool for working with Kubernetes clusters locally. It is particularly useful to quickly test code against different cluster [configurations](https://kind.sigs.k8s.io/docs/user/quick-start/#advanced).
1. Install [required tools](./DEVELOPMENT.md#install-tools) (note: may require a newer version of Go).
2. Install [Docker](https://www.docker.com/get-started).
Expand Down Expand Up @@ -353,7 +356,7 @@ While iterating on code changes to the project, you may need to:
- Update your (external) dependencies with: `./hack/update-deps.sh`
- Update your type definitions with: `./hack/update-codegen.sh`
- Update your OpenAPI specs with: `./hack/update-openapigen.sh`
1. Update or [add new CRD types](#adding-new-types) as needed
1. Update or [add new CRD types](#adding-new-crd-types) as needed
1. Update, [add and run tests](./test/README.md#tests)

To make changes to these CRDs, you will probably interact with:
Expand Down

0 comments on commit c52f937

Please sign in to comment.