Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matrix beta to roadmap #928

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Add matrix beta to roadmap #928

merged 1 commit into from
Jul 17, 2023

Conversation

afrittoli
Copy link
Member

The beta of the matrix feature (tracked in tektoncd/pipeline#5265) should be part of our 2023 roadmap.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 12, 2023
jerop
jerop reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding matrix beta to the roadmap

did you intend to include the TEP-0128 changes in this PR?

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2023
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 31, 2023
@afrittoli
Copy link
Member Author

/remove-lifecycle rotten

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 13, 2023
@afrittoli
Add matrix beta to the roadmap
6ed3b34 
Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli force-pushed the add_matrix_beta_to_roadmap branch from 3e3bda9 to 6ed3b34 Compare June 13, 2023 10:57
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2023
@afrittoli
Copy link
Member Author

+1 for adding matrix beta to the roadmap

did you intend to include the TEP-0128 changes in this PR?

Thanks @jerop - fixed that now

jerop
jerop approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@pritidesai
Copy link
Member

I wanted to highlight that tektoncd/pipeline#5266 is listed as one of the optional features and must not block the promotion of matrix to beta.

/approve

@pritidesai
Copy link
Member

Hey @afrittoli this sound a little weird since you are the author:

To complete the pull request process, please ask for approval from afrittoli after the PR has been reviewed.

I will try closing and re-opening this!

@pritidesai pritidesai closed this Jul 17, 2023
@pritidesai pritidesai reopened this Jul 17, 2023
@pritidesai pritidesai added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jerop, pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 9d162e9 into tektoncd:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@pritidesai pritidesai pritidesai approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afrittoli @tekton-robot @pritidesai @jerop