Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu 22.04 temporarly to fix the E2E #1228

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 11, 2024

Changes

ubuntu-latest (24.04) doesn't have /etc/docker/daemon.json anymore (by default at least), making some action we use fail.

This should unblock the CI until we update these actions.

cc @wlynch @lcarva

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

ubuntu-latest (24.04) doesn't have /etc/docker/daemon.json anymore (by
default at least), making some action we use fail.

This should unblock the CI until we update these actions.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2024
@tekton-robot tekton-robot requested review from lcarva and wlynch October 11, 2024 10:59
@vdemeester
Copy link
Member Author

/retest

@PuneetPunamiya
Copy link
Member

LGTM

Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@tekton-robot tekton-robot merged commit 8c9c153 into tektoncd:main Oct 14, 2024
16 checks passed
@vdemeester vdemeester deleted the use-ubuntu-22.04 branch October 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants