Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mongo server url path #1213

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Support mongo server url path #1213

merged 1 commit into from
Oct 10, 2024

Conversation

PuneetPunamiya
Copy link
Member

  • Previously when storage.docdb.mongo-server-url-dir was set, then value was read from the path specified in the field plus MONGO_SERVER_URL i.e. (for e.g. /mnt/mongo-creds-secret/MONGO_SERVER_URL) so user had to create the secret with the key MONGO_SERVER_URL

  • Hence, with this patch user can specify the path now and the tokwn will be read from the path specified

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 73.6% 64.2% -9.3

@PuneetPunamiya PuneetPunamiya force-pushed the fix-mongo-config branch 2 times, most recently from c6d30fd to 1615c58 Compare September 24, 2024 10:55
@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-chains-unit-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 73.6% 54.1% -19.4

jkhelil
jkhelil reviewed Sep 24, 2024
View reviewed changes
pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
savitaashture
savitaashture reviewed Sep 24, 2024
View reviewed changes
docs/config.md Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved
docs/config.md Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 73.6% 64.3% -9.3

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 73.6% 64.3% -9.3

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 73.6% 64.3% -9.3

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 73.6% 64.3% -9.3

lcarva
lcarva reviewed Sep 27, 2024
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved
pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 73.6% 64.6% -9.0

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-chains-integration-tests

lcarva
lcarva reviewed Oct 10, 2024
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
@PuneetPunamiya
Support mongo server url path
cd6eae2 
Previously when `storage.docdb.mongo-server-url-dir` was set, then value
was read from the path specified in the field plus `MONGO_SERVER_URL`
i.e. (for e.g. /mnt/mongo-creds-secret/MONGO_SERVER_URL) so user had to
create the secret with the key `MONGO_SERVER_URL`

Hence, with this patch user can specify the path now and the tokwn will
be read from the path specified

Signed-off-by: PuneetPunamiya <[email protected]>
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/docdb/docdb.go 48.8% 41.8% -7.0

lcarva
lcarva approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil, lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@tekton-robot tekton-robot merged commit 69a8f5f into tektoncd:main Oct 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@jkhelil jkhelil jkhelil approved these changes

@lcarva lcarva lcarva approved these changes

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PuneetPunamiya @tekton-robot @lcarva @jkhelil @savitaashture