Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch container images from gcr.io to ghcr.io #1313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Dec 18, 2024

Changes

Replace all references to images on gcr.io with the corresponding copy on ghcr.io. The target images are identical to the source ones, so there is no functional change in tasks or stepaction.

This PR changes old versions of tasks too and no new version is created, which should make it easier for people to start pulling from ghcr.io instead of gcr.io.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

Replace all references to images on gcr.io with the corresponding
copy on ghcr.io. The target images are identical to the source ones,
so there is no functional change in tasks or stepaction.

This PR changes old versions of tasks too and no new version is
created, which should make it easier for people to start pulling
from ghcr.io instead of gcr.io.

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vinamra28 after the PR has been reviewed.
You can assign the PR to them by writing /assign @vinamra28 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2024
@tekton-robot
Copy link

Catlin Output
FILE: task/codecov/0.1/codecov.yaml
WARN : Step "codecov-run" uses image "ghcr.io/tektoncd/plumbing/test-runner@sha256:44aa00796831a4ed5586152058dd96a6d14174b8a4ea9fcae663fb37f72c9454"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/git-batch-merge/0.1/git-batch-merge.yaml
WARN : Step "clone" references "$(params.subdirectory)" directly from its script block. For reliability and security, consider putting the param into an environment variable of the Step and accessing that environment variable in your script instead.
FILE: task/git-batch-merge/0.2/git-batch-merge.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.1/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.2/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.3/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.4/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.5/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.6/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.7/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.8/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.9/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/kaniko/0.1/kaniko.yaml
HINT : Task: tekton.dev/v1beta1 - name: "kaniko" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "docker.io/stedolan/jq@sha256:a61ed0bca213081b64be94c5e1b402ea58bc549f457c2682a86704dd55231e09"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/kaniko/0.2/kaniko.yaml
HINT : Task: tekton.dev/v1beta1 - name: "kaniko" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "docker.io/stedolan/jq@sha256:a61ed0bca213081b64be94c5e1b402ea58bc549f457c2682a86704dd55231e09"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/kaniko/0.3/kaniko.yaml
HINT : Task: tekton.dev/v1beta1 - name: "kaniko" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "docker.io/stedolan/jq@sha256:a61ed0bca213081b64be94c5e1b402ea58bc549f457c2682a86704dd55231e09"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/kaniko/0.4/kaniko.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.JQ_IMAGE)" that contains variables; skipping validation
FILE: task/kubeconfig-creator/0.1/kubeconfig-creator.yaml
WARN : Step "write" uses image "ghcr.io/tektoncd/github.com/tektoncd/pipeline/cmd/kubeconfigwriter@sha256:b2c6d0962cda88fb3095128b6202da9b0e6c9c0df3ef6cf7863505ffd25072fd"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/pull-request/0.1/pull-request.yaml
WARN : Step "pullrequest-init" uses image "ghcr.io/tektoncd/github.com/tektoncd/pipeline/cmd/pullrequest-init@sha256:69633ecd0e948f6462c61bb9e008b940a05b143ef51c67e6e4093278a23dac53"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/tekton-catalog-publish/0.1/tekton-catalog-publish.yaml
WARN : Step "publish" uses image "$(params.TKN_IMAGE)" that contains variables; skipping validation
FILE: task/tkn/0.1/tkn.yaml
HINT : Task: tekton.dev/v1beta1 - name: "tkn" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "tkn" uses image "$(params.tkn-image)" that contains variables; skipping validation
FILE: task/tkn/0.2/tkn.yaml
WARN : Step "tkn" uses image "$(params.TKN_IMAGE)" that contains variables; skipping validation
FILE: task/tkn/0.3/tkn.yaml
WARN : Step "tkn" uses image "$(params.TKN_IMAGE)" that contains variables; skipping validation
FILE: task/tkn/0.4/tkn.yaml
WARN : Step "tkn" uses image "$(params.TKN_IMAGE)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s bash] failed:

In codecov-codecov-run line 2:
bash <(wget -O- -o/dev/null https://codecov.io/bash) $@
                                                     ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-batch-merge-clone line 9:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 11:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .


In git-batch-merge-clone line 19:
if [[ "$(params.deleteExisting)" == "true" ]] ; then
   ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 38:
git -C $CHECKOUT_DIR config user.name "$(params.gitUserName)"
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
git -C "$CHECKOUT_DIR" config user.name "$(params.gitUserName)"


In git-batch-merge-clone line 39:
git -C $CHECKOUT_DIR config user.email "$(params.gitUserEmail)"
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
git -C "$CHECKOUT_DIR" config user.email "$(params.gitUserEmail)"


In git-batch-merge-clone line 42:
if [[ $mode == "merge" ]]; then
   ^--------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 44:
     git -C $CHECKOUT_DIR merge --quiet --allow-unrelated-histories refs/batch/$ref
            ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
     git -C "$CHECKOUT_DIR" merge --quiet --allow-unrelated-histories refs/batch/"$ref"


In git-batch-merge-clone line 46:
elif [[ $mode == "cherry-pick" ]]; then
     ^--------------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 48:
     git -C $CHECKOUT_DIR cherry-pick --allow-empty --keep-redundant-commits refs/batch/$ref
            ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
     git -C "$CHECKOUT_DIR" cherry-pick --allow-empty --keep-redundant-commits refs/batch/"$ref"


In git-batch-merge-clone line 55:
RESULT_SHA="$(git -C $CHECKOUT_DIR rev-parse HEAD)"
                     ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
RESULT_SHA="$(git -C "$CHECKOUT_DIR" rev-parse HEAD)"


In git-batch-merge-clone line 56:
TREE_SHA="$(git -C $CHECKOUT_DIR rev-parse HEAD^{tree})"
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.

Did you mean: 
TREE_SHA="$(git -C "$CHECKOUT_DIR" rev-parse HEAD^{tree})"


In git-batch-merge-clone line 58:
echo -n "$(echo $RESULT_SHA | tr -d '\n')" > $(results.commit.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean: 
echo -n "$(echo "$RESULT_SHA" | tr -d '\n')" > $(results.commit.path)


In git-batch-merge-clone line 59:
echo -n "$(echo $TREE_SHA | tr -d '\n')" > $(results.tree.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean: 
echo -n "$(echo "$TREE_SHA" | tr -d '\n')" > $(results.tree.path)

For more information:
  https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-batch-merge-clone line 9:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 11:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .


In git-batch-merge-clone line 19:
if [[ "$(params.deleteExisting)" == "true" ]] ; then
   ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 38:
git -C $CHECKOUT_DIR config user.name "$(params.gitUserName)"
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
git -C "$CHECKOUT_DIR" config user.name "$(params.gitUserName)"


In git-batch-merge-clone line 39:
git -C $CHECKOUT_DIR config user.email "$(params.gitUserEmail)"
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
git -C "$CHECKOUT_DIR" config user.email "$(params.gitUserEmail)"


In git-batch-merge-clone line 42:
if [[ $mode == "merge" ]]; then
   ^--------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 44:
     git -C $CHECKOUT_DIR merge --quiet --allow-unrelated-histories refs/batch/$ref
            ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
     git -C "$CHECKOUT_DIR" merge --quiet --allow-unrelated-histories refs/batch/"$ref"


In git-batch-merge-clone line 46:
elif [[ $mode == "cherry-pick" ]]; then
     ^--------------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-batch-merge-clone line 48:
     git -C $CHECKOUT_DIR cherry-pick --allow-empty --keep-redundant-commits refs/batch/$ref
            ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
     git -C "$CHECKOUT_DIR" cherry-pick --allow-empty --keep-redundant-commits refs/batch/"$ref"


In git-batch-merge-clone line 55:
RESULT_SHA="$(git -C $CHECKOUT_DIR rev-parse HEAD)"
                     ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
RESULT_SHA="$(git -C "$CHECKOUT_DIR" rev-parse HEAD)"


In git-batch-merge-clone line 56:
TREE_SHA="$(git -C $CHECKOUT_DIR rev-parse HEAD^{tree})"
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.

Did you mean: 
TREE_SHA="$(git -C "$CHECKOUT_DIR" rev-parse HEAD^{tree})"


In git-batch-merge-clone line 58:
echo -n "$(echo $RESULT_SHA | tr -d '\n')" > $(results.commit.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean: 
echo -n "$(echo "$RESULT_SHA" | tr -d '\n')" > $(results.commit.path)


In git-batch-merge-clone line 59:
echo -n "$(echo $TREE_SHA | tr -d '\n')" > $(results.tree.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean: 
echo -n "$(echo "$TREE_SHA" | tr -d '\n')" > $(results.tree.path)

For more information:
  https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-clone-clone line 9:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 11:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .


In git-clone-clone line 19:
if [[ "${PARAM_DELETE_EXISTING}" == "true" ]] ; then
   ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 35:
cd "$CHECKOUT_DIR"
^----------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean: 
cd "$CHECKOUT_DIR" || exit


In git-clone-clone line 43:
echo -n "$RESULT_SHA" > $(results.commit.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...
  https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |...

WARN : step: git-clone is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-clone-clone line 2:
set -eu -o pipefail
           ^------^ SC3040 (warning): In POSIX sh, set option pipefail is undefined.


In git-clone-clone line 4:
if [[ "${PARAM_VERBOSE}" == "true" ]] ; then
   ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 15:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 17:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .


In git-clone-clone line 25:
if [[ "${PARAM_DELETE_EXISTING}" == "true" ]] ; then
   ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 48:
echo -n "$RESULT_SHA" > $(results.commit.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.


In git-clone-clone line 49:
echo -n "${PARAM_URL}" > $(results.url.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                         ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...
  https://www.shellcheck.net/wiki/SC3010 -- In POSIX sh, [[ ]] is undefined.

WARN : step: git-clone is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-clone-clone line 2:
set -eu -o pipefail
           ^------^ SC3040 (warning): In POSIX sh, set option pipefail is undefined.


In git-clone-clone line 4:
if [[ "${PARAM_VERBOSE}" == "true" ]] ; then
   ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 15:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 17:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .


In git-clone-clone line 25:
if [[ "${PARAM_DELETE_EXISTING}" == "true" ]] ; then
   ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 49:
echo -n "$RESULT_SHA" > $(results.commit.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.


In git-clone-clone line 50:
echo -n "${PARAM_URL}" > $(results.url.path)
     ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
                         ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...
  https://www.shellcheck.net/wiki/SC3010 -- In POSIX sh, [[ ]] is undefined.

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In kaniko-digest-to-results line 2:
cat $(params.CONTEXT)/image-digested | jq '.[0].value' -rj | tee $(results.IMAGE-DIGEST.path)
    ^---------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                 ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In kaniko-digest-to-results line 2:
cat $(params.CONTEXT)/image-digested | jq '.[0].value' -rj | tee $(results.IMAGE-DIGEST.path)
    ^---------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                 ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In kaniko-digest-to-results line 2:
cat $(params.CONTEXT)/image-digested | jq '.[0].value' -rj | tee $(results.IMAGE-DIGEST.path)
    ^---------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                 ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In kaniko-digest-to-results line 2:
cat $(params.CONTEXT)/image-digested | jq '.[0].value' -rj | tee $(results.IMAGE-DIGEST.path)
    ^---------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                 ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In tekton-catalog-publish-publish line 2:
set -e -o pipefail
          ^------^ SC3040 (warning): In POSIX sh, set option pipefail is undefined.

For more information:
  https://www.shellcheck.net/wiki/SC3040 -- In POSIX sh, set option pipefail ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In tkn-tkn line 2:
if [ "$(workspaces.kubeconfig.bound)" == "true" ] && [[ -e $(workspaces.kubeconfig.path)/kubeconfig ]]; then
                                      ^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.
                                                     ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In tkn-tkn line 3:
  export KUBECONFIG=$(workspaces.kubeconfig.path)/kubeconfig
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                    ^---------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In tkn-tkn line 6:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In tkn-tkn line 2:
if [ "$(workspaces.kubeconfig.bound)" == "true" ] && [[ -e $(workspaces.kubeconfig.path)/kubeconfig ]]; then
                                      ^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.
                                                     ^-- SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In tkn-tkn line 3:
  export KUBECONFIG=$(workspaces.kubeconfig.path)/kubeconfig
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                    ^---------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In tkn-tkn line 6:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In tkn-tkn line 2:
if [ "$(workspaces.kubeconfig.bound)" = "true" ] && [ -e $(workspaces.kubeconfig.path)/kubeconfig ]; then
                                                         ^---------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In tkn-tkn line 3:
  export KUBECONFIG="$(workspaces.kubeconfig.path)"/kubeconfig
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

@afrittoli
Copy link
Member Author

/retest

@tekton-robot
Copy link

@afrittoli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-catalog-integration-tests ea27d33 link true /test pull-tekton-catalog-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants