Update openshift-client.yaml with optional results field

[Shrubberer]

Added a results field with an optional RESULT to emit output for use in pipeline or next tasks. The default value is set to an empty string according to TEP-0048: Task Results without Results.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Follows the authoring recommendations
• Includes docs (if user facing)
• Includes tests (for new tasks or changed functionality)
  • See the end-to-end testing documentation for guidance and CI details.
• Meets the Tekton contributor standards (including functionality, content, code)
• Commit messages follow commit message best practices
• Has a kind label. You can add one by adding a comment on this PR that
  contains /kind <type>. Valid types are bug, cleanup, design, documentation,
  feature, flake, misc, question, tep
• Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation

  • File path follows <kind>/<name>/<version>/name.yaml

  • Has README.md at <kind>/<name>/<version>/README.md

  • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

  • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

  • mandatory spec.description follows the convention

      ```
    
      spec:
        description: >-
          one line summary of the resource
    
          Paragraph(s) to describe the resource.
      ```
    

See the contribution guide for more details.

[linux-foundation-easycla]

• ✅login: Shrubberer / (99ec25a)

The committers listed above are authorized under a signed CLA.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign piyush-garg after the PR has been reviewed.
You can assign the PR to them by writing /assign @piyush-garg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• task/openshift-client/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

Hi @Shrubberer. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following Tekton test failed:

Test name	Commit	Details	Required	Rerun command
pull-catalog-catlin-lint	99ec25a	link	true	/test pull-catalog-catlin-lint

[tekton-robot]

Catlin Output

FILE: task/openshift-client/0.2/openshift-client.yaml
WARN : Step "oc" uses image "quay.io/openshift/origin-cli:$(params.VERSION)" that contains variables; skipping validation

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In openshift-client-oc line 4:
cd $(workspaces.manifest-dir.path)
^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
   ^-----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean: 
cd $(workspaces.manifest-dir.path) || exit


In openshift-client-oc line 8:
export KUBECONFIG=$(workspaces.kubeconfig-dir.path)/kubeconfig
       ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In openshift-client-oc line 10:
echo "" > $(results.RESULT.path)
          ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.


In openshift-client-oc line 12:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

[vinamra28]

hi @Shrubberer, can you please sign the CLA?