This is a hail mary

teenageknight · Sep 22, 2024 · df80a18 · df80a18
1 parent 875b4c9
commit df80a18
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.github/workflows/Deploy-Firebase-Function.yml b/.github/workflows/Deploy-Firebase-Function.yml
@@ -17,3 +17,4 @@ jobs:
               run: cd functions/ && npx firebase-tools use prod && npx firebase-tools deploy --only functions
               env:
                   FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
+                  FIREBASE_SERVICE_ACCOUNT: ${{ secrets.FIREBASE_SERVICE_ACCOUNT }}
diff --git a/functions/src/index.ts b/functions/src/index.ts
@@ -89,6 +89,9 @@ function parseAddress(address_query_geocode: string, geocodio_address: any) {
     return address;
 }
 
+/*
+This secret is defined using the firebase secrets manager, not the github secrets manager.
+*/
 export const validateAddresses = onCall({ timeoutSeconds: 120, secrets: ["GEOCODIO_API_KEY"] }, async request => {
     console.log("request.body", request.data.addresses);
     console.log("request.body", request.data.addresses.length);